From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
Date: Sat, 25 May 2013 15:04:00 -0000 [thread overview]
Message-ID: <51A0D2EC.80209@redhat.com> (raw)
In-Reply-To: <yjt24ndru9yf.fsf@ruffy2.mtv.corp.google.com>
Fun. Thanks for the detailed analysis.
On 05/25/2013 02:25 AM, Doug Evans wrote:
> - *(int *)base = desc[1];
> + /* Ensure we properly extend the value to 64-bits for x86_64. */
> + *base = (void*) (uintptr_t) desc[1];
missing space: 'void *'.
Otherwise OK.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-05-25 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 1:25 Doug Evans
2013-05-25 15:04 ` Pedro Alves [this message]
2013-06-05 21:28 ` Doug Evans
2013-06-06 5:20 ` Joel Brobecker
2013-06-06 18:00 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A0D2EC.80209@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox