From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102215-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29311 invoked by alias); 5 Jun 2013 21:28:20 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29301 invoked by uid 89); 5 Jun 2013 21:28:20 -0000
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 05 Jun 2013 21:28:19 +0000
Received: by mail-vc0-f169.google.com with SMTP id ia10so1525990vcb.28        for <gdb-patches@sourceware.org>; Wed, 05 Jun 2013 14:28:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :cc:content-type:x-gm-message-state;        bh=Y/EuSPMHTfQsNc3zIt06+ncMPZzdI4jJj3zr7soa6h4=;        b=oLvCyIlerHa17tHWKz3AFRgJgN8keokIe162S8l7XN3m668xcB8c11Kj0lJS7X9apW         VcXbEkQKIUxwGFyGapzCnSC+8lByAIF1tCNh1Dr30Wm4lZ/jV37yuW9LJ4ffXuiZ6ybr         /oG2cxblW9jEKewcDFDdSxCCsL0VrG4TxuTGIKmO+piZ4fG8odgbB0DYw4UeJvDi5l+O         VP4bjClDftWxJzIGCtvNC5vsChYHZc3JP2/gne7n4/xOKZY471MYEjo5eMMvS/+ltoGc         GxsFctxGVht8NMRrvHrYXI7zGNepeOrkgJF0B1HQi/6495U7jku/u43k8GRMJjAuD4MQ         UzJQ==
MIME-Version: 1.0
X-Received: by 10.52.231.36 with SMTP id td4mr17911528vdc.92.1370467697105; Wed, 05 Jun 2013 14:28:17 -0700 (PDT)
Received: by 10.220.189.74 with HTTP; Wed, 5 Jun 2013 14:28:17 -0700 (PDT)
In-Reply-To: <51A0D2EC.80209@redhat.com>
References: <yjt24ndru9yf.fsf@ruffy2.mtv.corp.google.com>	<51A0D2EC.80209@redhat.com>
Date: Wed, 05 Jun 2013 21:28:00 -0000
Message-ID: <CADPb22TsiiaNfY1yqRyNhCe8O-d2Ld6oYUkehk4zz1i3CzspOA@mail.gmail.com>
Subject: Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQmqqVY3X5aBg8BLWXeV5vunM8xmOiF4TfogrH5w9MA9kLzHpeNOhndgpVR1coegLU3cc+3Tgwz/100CD8PTAk6HlTDCvUlNzQ4a9RE9qtNiSGDGyE82HC+Em2Io2tNQPbYPoilW7E0engA8UoD0HbI/qVId/CFTgDdYg9mOtK30XVSQ+UxakwcSZc38ow0UaRhIp0HnmbYvz/ItQtGsiTrQjCU1Sw==
X-SW-Source: 2013-06/txt/msg00099.txt.bz2

On Sat, May 25, 2013 at 8:04 AM, Pedro Alves <palves@redhat.com> wrote:
> Fun.  Thanks for the detailed analysis.
>
> On 05/25/2013 02:25 AM, Doug Evans wrote:
>
>> -    *(int *)base = desc[1];
>> +    /* Ensure we properly extend the value to 64-bits for x86_64.  */
>> +    *base = (void*) (uintptr_t) desc[1];
>
> missing space: 'void *'.
>
> Otherwise OK.
>
> Thanks,
> --
> Pedro Alves

Patch committed to 7.6 branch as well (and 7.6 wiki updated).