From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] Perf test framework
Date: Fri, 25 Oct 2013 06:33:00 -0000 [thread overview]
Message-ID: <CADPb22TU_-Wv+Y5PAanBPgza9Gx=RFcou-7O2_AZrhKkW4-aOg@mail.gmail.com> (raw)
In-Reply-To: <525E569E.3050101@codesourcery.com>
On Wed, Oct 16, 2013 at 2:04 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 10/16/2013 03:09 PM, Yao Qi wrote:
>> + def start(self, id):
>> + foo = 0
>
> Missed the change during git rebase. "pass" should be used here.
> Here is an updated one.
Heh. Read this after sending my review.
next prev parent reply other threads:[~2013-10-25 6:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 7:10 [PATCH 0/4 V3] GDB Performance testing Yao Qi
2013-10-16 7:10 ` [PATCH 2/4] Perf test framework Yao Qi
2013-10-16 9:05 ` Yao Qi
2013-10-24 14:20 ` Yao Qi
2013-10-25 6:33 ` Doug Evans [this message]
2013-10-25 6:32 ` Doug Evans
2013-10-25 8:57 ` Yao Qi
2013-10-16 7:10 ` [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf Yao Qi
2013-10-25 3:04 ` Doug Evans
2013-10-25 17:34 ` Pedro Alves
2013-10-16 7:10 ` [PATCH 4/4] Test on solib load and unload Yao Qi
2013-10-25 7:17 ` Doug Evans
2013-10-16 7:10 ` [PATCH 3/4] Mention perf test in testsuite/README Yao Qi
2013-10-25 6:43 ` Doug Evans
2013-10-24 2:44 ` ping: [PATCH 0/4 V3] GDB Performance testing Yao Qi
2013-10-24 8:50 ` Agovic, Sanimir
2013-10-24 14:13 ` Yao Qi
2013-10-25 2:59 ` Doug Evans
2013-11-01 7:36 [PATCH 0/4 V4] " Yao Qi
2013-11-01 7:36 ` [PATCH 2/4] Perf test framework Yao Qi
2013-11-01 19:43 ` Doug Evans
2013-11-01 20:46 ` Tom Tromey
2013-11-02 2:42 ` Yao Qi
2013-11-04 16:27 ` Tom Tromey
2013-11-06 5:30 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TU_-Wv+Y5PAanBPgza9Gx=RFcou-7O2_AZrhKkW4-aOg@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox