From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] Perf test framework
Date: Wed, 06 Nov 2013 05:30:00 -0000 [thread overview]
Message-ID: <5279D204.4020700@codesourcery.com> (raw)
In-Reply-To: <87sivcuoch.fsf@fleche.redhat.com>
On 11/05/2013 12:24 AM, Tom Tromey wrote:
> Yao> + if { "$GDB_PERFTEST_MODE" != "compile"
> Yao> + && "$GDB_PERFTEST_MODE" != "run"
> Yao> + && "$GDB_PERFTEST_MODE" != "both" } {
> Yao> + # GDB_PERFTEST_MODE=compile|run|both is allowed.
> Yao> + unsupported "Unknown value of GDB_PERFTEST_MODE."
> Yao> + return 1
>
> This is basically an internal error.
> Calling "error" and having a backtrace in the log seems better to me.
Fixed it in the commit. Thanks for the review.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-11-06 5:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 7:36 [PATCH 0/4 V4] GDB Performance testing Yao Qi
2013-11-01 7:36 ` [PATCH 3/4] Mention perf test in testsuite/README Yao Qi
2013-11-01 7:36 ` [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf Yao Qi
2013-11-01 7:36 ` [PATCH 2/4] Perf test framework Yao Qi
2013-11-01 19:43 ` Doug Evans
2013-11-01 20:46 ` Tom Tromey
2013-11-02 2:42 ` Yao Qi
2013-11-04 16:27 ` Tom Tromey
2013-11-06 5:30 ` Yao Qi [this message]
2013-11-01 7:36 ` [PATCH 4/4] Test on solib load and unload Yao Qi
2013-11-01 20:35 ` Tom Tromey
2013-11-02 2:50 ` Yao Qi
2013-11-04 17:37 ` Tom Tromey
2013-11-06 6:42 ` [PATCH 0/4 V4] GDB Performance testing Yao Qi
-- strict thread matches above, loose matches on Subject: below --
2013-10-16 7:10 [PATCH 0/4 V3] " Yao Qi
2013-10-16 7:10 ` [PATCH 2/4] Perf test framework Yao Qi
2013-10-16 9:05 ` Yao Qi
2013-10-24 14:20 ` Yao Qi
2013-10-25 6:33 ` Doug Evans
2013-10-25 6:32 ` Doug Evans
2013-10-25 8:57 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5279D204.4020700@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox