From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24093 invoked by alias); 6 Nov 2013 05:24:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24075 invoked by uid 89); 6 Nov 2013 05:24:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY,RDNS_NONE autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2013 05:23:59 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Vdvag-0005YS-Bn from Yao_Qi@mentor.com ; Tue, 05 Nov 2013 21:23:42 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 5 Nov 2013 21:23:42 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 5 Nov 2013 21:23:40 -0800 Message-ID: <5279D204.4020700@codesourcery.com> Date: Wed, 06 Nov 2013 05:30:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 2/4] Perf test framework References: <1383291300-13917-1-git-send-email-yao@codesourcery.com> <1383291300-13917-3-git-send-email-yao@codesourcery.com> <877gcryhnz.fsf@fleche.redhat.com> <52746636.8080102@codesourcery.com> <87sivcuoch.fsf@fleche.redhat.com> In-Reply-To: <87sivcuoch.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00104.txt.bz2 On 11/05/2013 12:24 AM, Tom Tromey wrote: > Yao> + if { "$GDB_PERFTEST_MODE" != "compile" > Yao> + && "$GDB_PERFTEST_MODE" != "run" > Yao> + && "$GDB_PERFTEST_MODE" != "both" } { > Yao> + # GDB_PERFTEST_MODE=compile|run|both is allowed. > Yao> + unsupported "Unknown value of GDB_PERFTEST_MODE." > Yao> + return 1 > > This is basically an internal error. > Calling "error" and having a backtrace in the log seems better to me. Fixed it in the commit. Thanks for the review. -- Yao (齐尧)