Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf
Date: Fri, 25 Oct 2013 03:04:00 -0000	[thread overview]
Message-ID: <CADPb22RbqOOnjaNvT30O-ENC1dPEr=TH+Q6sLvN6pjhnsB=OwA@mail.gmail.com> (raw)
In-Reply-To: <1381907353-30013-2-git-send-email-yao@codesourcery.com>

On Wed, Oct 16, 2013 at 12:09 AM, Yao Qi <yao@codesourcery.com> wrote:
> We add a new dir gdb.perf in testsuite for all performance tests.
> However, current 'make check' logic will either run dejagnu in
> directory testsuite or iterate all gdb.* directories which has *.exp
> files.  Both of them will run tests in gdb.perf.  We want to achieve:
>
>  1) typical 'make check' should not run performance tests.  In each perf
>     test case, GDB_PERFORMANCE is checked.  If it doesn't exist, return.
>  2) run perf tests easily.  We add a new makefile target 'check-perf'.
>
> V2 is simpler than V1, since we don't have to filter out gdb.perf
> directory.
>
> V3: Move GDB_PERFORMANCE=both appears before RUNTESTFLAGS.  It was
> approved by Doug.
>
> gdb:
>
> 2013-10-16  Yao Qi  <yao@codesourcery.com>
>
>         * Makefile.in (check-perf): New target.
>
> gdb/testsuite:
>
> 2013-10-16  Yao Qi  <yao@codesourcery.com>
>
>         * Makefile.in (check-perf): New target.
>         * configure.ac (AC_OUTPUT): Output Makefile in gdb.perf.
>         * configure: Re-generated.
>         * gdb.perf/Makefile.in: New.

No more comments to add here, other than while I think I suggested
"GDB_PERFORMANCE=both" every time I read it I keep thinking there has
to be a better word to use here than "both".  :-)
"compile-and-run" is too long.
I'm not suggesting changing anything, just wondering if anyone else
has a better word.


  reply	other threads:[~2013-10-25  3:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  7:10 [PATCH 0/4 V3] GDB Performance testing Yao Qi
2013-10-16  7:10 ` [PATCH 3/4] Mention perf test in testsuite/README Yao Qi
2013-10-25  6:43   ` Doug Evans
2013-10-16  7:10 ` [PATCH 4/4] Test on solib load and unload Yao Qi
2013-10-25  7:17   ` Doug Evans
2013-10-16  7:10 ` [PATCH 2/4] Perf test framework Yao Qi
2013-10-16  9:05   ` Yao Qi
2013-10-24 14:20     ` Yao Qi
2013-10-25  6:33     ` Doug Evans
2013-10-25  6:32   ` Doug Evans
2013-10-25  8:57     ` Yao Qi
2013-10-16  7:10 ` [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf Yao Qi
2013-10-25  3:04   ` Doug Evans [this message]
2013-10-25 17:34     ` Pedro Alves
2013-10-24  2:44 ` ping: [PATCH 0/4 V3] GDB Performance testing Yao Qi
2013-10-24  8:50   ` Agovic, Sanimir
2013-10-24 14:13     ` Yao Qi
2013-10-25  2:59 ` Doug Evans
2013-11-01  7:36 [PATCH 0/4 V4] " Yao Qi
2013-11-01  7:36 ` [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22RbqOOnjaNvT30O-ENC1dPEr=TH+Q6sLvN6pjhnsB=OwA@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox