From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23544 invoked by alias); 25 Oct 2013 03:04:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23521 invoked by uid 89); 25 Oct 2013 03:04:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f180.google.com Received: from mail-ve0-f180.google.com (HELO mail-ve0-f180.google.com) (209.85.128.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 25 Oct 2013 03:04:14 +0000 Received: by mail-ve0-f180.google.com with SMTP id db12so2370428veb.39 for ; Thu, 24 Oct 2013 20:04:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=QLOtaU5cO1QN+XzELxQRBJH3jFvedB26+cfIcuVRgto=; b=Xr2mqOLchsUh0m2454MxNb796RlsGTZ3nITQ0Z4Tr2CKVWhcm7kYUrHUuUsOwH0iCi yMCZ7gWTN7anxzA43TuIFPQ6HBdBEfU1sZifh5mPH6GtSV/6D7ttN/Shm1MzO08sR3sy dc19MwHUN0U7uqi3F8rhN31n9XPYsQIe4vkKeDC0xHYdUB44N51L5iRGGoNkyYspHraz wWO78a+2Vj/pcKeDhDgoCQP3qSJ5yFZEuWKSTt3mY1wNFo2ujCI+9wxdIEsZr8NL0SCH jROQBMdrsDPfMcSgrml8L/F+1sRey+DGMuBZq6uf3EqQjm6v0OgXvNrtLSTJBPtVifbQ rSDw== X-Gm-Message-State: ALoCoQlO3cEcB/wajXw+AkWHok3biuMRz5oXzQacs273c+aamxRqnNAPKGE/lSxcbwbnVHKRbTqFdePogxzOLagfHp8BG8uBQQew9dZw7TS5bPA+fF7iPSQFoTnn7GOUPbNN/kdDjWx0ticp2fSJeqBua9KU1aO5BIQBCLIYOpN0uF5aeyIMXRh+s2t7sBjCVZdd66vosCU2lBJEyEPT0mDnLB3taXTgNA== MIME-Version: 1.0 X-Received: by 10.58.29.37 with SMTP id g5mr371642veh.38.1382670252558; Thu, 24 Oct 2013 20:04:12 -0700 (PDT) Received: by 10.52.37.138 with HTTP; Thu, 24 Oct 2013 20:04:12 -0700 (PDT) In-Reply-To: <1381907353-30013-2-git-send-email-yao@codesourcery.com> References: <1381907353-30013-1-git-send-email-yao@codesourcery.com> <1381907353-30013-2-git-send-email-yao@codesourcery.com> Date: Fri, 25 Oct 2013 03:04:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] New make target 'check-perf' and new dir gdb.perf From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00774.txt.bz2 On Wed, Oct 16, 2013 at 12:09 AM, Yao Qi wrote: > We add a new dir gdb.perf in testsuite for all performance tests. > However, current 'make check' logic will either run dejagnu in > directory testsuite or iterate all gdb.* directories which has *.exp > files. Both of them will run tests in gdb.perf. We want to achieve: > > 1) typical 'make check' should not run performance tests. In each perf > test case, GDB_PERFORMANCE is checked. If it doesn't exist, return. > 2) run perf tests easily. We add a new makefile target 'check-perf'. > > V2 is simpler than V1, since we don't have to filter out gdb.perf > directory. > > V3: Move GDB_PERFORMANCE=both appears before RUNTESTFLAGS. It was > approved by Doug. > > gdb: > > 2013-10-16 Yao Qi > > * Makefile.in (check-perf): New target. > > gdb/testsuite: > > 2013-10-16 Yao Qi > > * Makefile.in (check-perf): New target. > * configure.ac (AC_OUTPUT): Output Makefile in gdb.perf. > * configure: Re-generated. > * gdb.perf/Makefile.in: New. No more comments to add here, other than while I think I suggested "GDB_PERFORMANCE=both" every time I read it I keep thinking there has to be a better word to use here than "both". :-) "compile-and-run" is too long. I'm not suggesting changing anything, just wondering if anyone else has a better word.