From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Delete struct inferior_suspend_state
Date: Thu, 31 Jul 2014 19:54:00 -0000 [thread overview]
Message-ID: <CADPb22TPw+9eOv2hna==EomvmNNyATTkqUvwyqKLU7V-L=PAEA@mail.gmail.com> (raw)
In-Reply-To: <20140731193050.GA7927@host2.jankratochvil.net>
On Thu, Jul 31, 2014 at 12:30 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> I do not mind any way.
>
> But in the case it is deleted I believe it is better to keep there at least
> comments at the places where is currently #if 0. So if one is adding a new
> field one immediately knows where it should belong - to the 4 cases of 2x2
> matrix {thread,inferior}_{suspend,control}_state - in the case it would belong
> to the inferior+suspend combination.
Thanks.
If we're going to keep comments we might as well keep the #if 0'd code
(which is fine by me).
There's no real difference between the two, and the #if 0'd out code
is more descriptive, though I would add a commit (tweak a comment?) so
that the next person will more easily know that the #if 0's are ok.
IWBN to have examples where #if 0 is at least not a bad thing.
next prev parent reply other threads:[~2014-07-31 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 19:30 Doug Evans
2014-07-31 19:46 ` Jan Kratochvil
2014-07-31 19:54 ` Doug Evans [this message]
2014-07-31 20:33 ` Joel Brobecker
2014-07-31 20:42 ` Doug Evans
2014-07-31 20:58 ` Joel Brobecker
2014-07-31 21:11 ` Doug Evans
2014-07-31 21:53 ` Joel Brobecker
2014-08-01 2:04 ` Doug Evans
2014-08-08 23:25 ` Stan Shebs
2014-08-09 20:53 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22TPw+9eOv2hna==EomvmNNyATTkqUvwyqKLU7V-L=PAEA@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox