Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Delete struct inferior_suspend_state
Date: Thu, 31 Jul 2014 21:53:00 -0000	[thread overview]
Message-ID: <20140731211124.GA3132@adacore.com> (raw)
In-Reply-To: <CADPb22TSKj2HmCfpHKgurARrq1AE5_6Mm4juGXqZ6O2wF1RUyQ@mail.gmail.com>

> That's a general concern, yes.
> My comments in this thread are confined to the particular case at hand.

Jan was saying that he does not mind it if the code gets removed.
So I think we can remove it.

Jan also asked that we add a comment to mark the location where
the code should be add should we need it. I don't mind, but
these are about something that has become a fairly general and
standard paradigm, so I don't personally really see much usefulness
in that, while things may change in the future, making those
comments incomplete or incorrect.

Commented-out code should be avoided, and removed if found.
There are no absolute rules as far as I am concerned, so we may
one day face a situation where it's best to ignore that rule.
But we'd have to justify why that's best before going ahead.

In this particular case IMO, the convenience doesn't justify us
keeping the code around, so I would go ahead removing it.

-- 
Joel


  reply	other threads:[~2014-07-31 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 19:30 Doug Evans
2014-07-31 19:46 ` Jan Kratochvil
2014-07-31 19:54   ` Doug Evans
2014-07-31 20:33     ` Joel Brobecker
2014-07-31 20:42       ` Doug Evans
2014-07-31 20:58         ` Joel Brobecker
2014-07-31 21:11           ` Doug Evans
2014-07-31 21:53             ` Joel Brobecker [this message]
2014-08-01  2:04             ` Doug Evans
2014-08-08 23:25 ` Stan Shebs
2014-08-09 20:53   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731211124.GA3132@adacore.com \
    --to=brobecker@adacore.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox