From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13977 invoked by alias); 31 Jul 2014 19:46:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13948 invoked by uid 89); 31 Jul 2014 19:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f176.google.com Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 31 Jul 2014 19:46:40 +0000 Received: by mail-vc0-f176.google.com with SMTP id id10so5064239vcb.35 for ; Thu, 31 Jul 2014 12:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=s+Sa0nwOiUYohWIYn/QG3WuPjNYnkQHtOeWOkVWwaFY=; b=YdU6/kJcyGeBc5CJVxbhePSla55JZkcQe6exKzhcCepwd03B1JXC966ZzFsFXOJgcJ PsCLmf8pAhvSNE2/ajEAqBdlqxUZvA17pOhA5+CFs5el7OVbKZW4cZWxDBaxV9865HlN dB68fgJZVJmV1AdL+KXUj2VlVExeBs9GVgblHtGoqKivMPDm4YSsMNfFitkoofnCbAPq ET53sZONgiP23ZiMshE6GwMKjkM427sXIC6dLnaGZ85mQ/xS3Nz2x2uZFsI2tPVJ0aAa GcSF3J5Z2T/1pmeCtWqNLI4eoV54noIzBlVi8a75csoKHcdCx4EtV42DChX42Gy2lTof FxmQ== X-Gm-Message-State: ALoCoQlG5XEPA+/TtBfU+w4UELvNrIT+2t7kG/G7W83yz5ikdu6/T6vQugBTHkKE5fi7RMOmtY0l MIME-Version: 1.0 X-Received: by 10.52.78.65 with SMTP id z1mr505677vdw.67.1406835998549; Thu, 31 Jul 2014 12:46:38 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 31 Jul 2014 12:46:38 -0700 (PDT) In-Reply-To: <20140731193050.GA7927@host2.jankratochvil.net> References: <20140731193050.GA7927@host2.jankratochvil.net> Date: Thu, 31 Jul 2014 19:54:00 -0000 Message-ID: Subject: Re: [PATCH] Delete struct inferior_suspend_state From: Doug Evans To: Jan Kratochvil Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00832.txt.bz2 On Thu, Jul 31, 2014 at 12:30 PM, Jan Kratochvil wrote: > Hi, > > I do not mind any way. > > But in the case it is deleted I believe it is better to keep there at least > comments at the places where is currently #if 0. So if one is adding a new > field one immediately knows where it should belong - to the 4 cases of 2x2 > matrix {thread,inferior}_{suspend,control}_state - in the case it would belong > to the inferior+suspend combination. Thanks. If we're going to keep comments we might as well keep the #if 0'd code (which is fine by me). There's no real difference between the two, and the #if 0'd out code is more descriptive, though I would add a commit (tweak a comment?) so that the next person will more easily know that the #if 0's are ok. IWBN to have examples where #if 0 is at least not a bad thing.