From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Keith Seitz <keiths@redhat.com>,
"gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix gdb/15827 (crash w/corrupt DWARF)
Date: Fri, 21 Mar 2014 19:27:00 -0000 [thread overview]
Message-ID: <CADPb22TEcAUvoEm2FOe3rbc0AMBfcNCUYd-9vXLTbP1-F1f_8w@mail.gmail.com> (raw)
In-Reply-To: <20140321171453.GJ4282@adacore.com>
On Fri, Mar 21, 2014 at 10:14 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> +# If we get here and gdb hasn't crashed, the tests pass.
>> +pass "corrupt DWARF"
>
> That's just me but I usually do a "print 1" test, just to make sure
> that even if the testing framework did not detect the GDB process
> dying, the "print 1" test definitely will. Not important on most,
> if not all platforms, but ISTR some odd platforms where this helped.
> That's just a suggestion, you don't have to follow it.
Not that this needs to be added to this patch, but IWBN to codify this
in a utility routine, some tcl proc that does "print 1" or whatever
and verifies the expected result. The point is to encapsulate the
intent in a suitably named function, verify_gdb_alive or some such.
prev parent reply other threads:[~2014-03-21 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 16:48 Keith Seitz
2014-03-21 17:14 ` Joel Brobecker
2014-03-21 17:26 ` Keith Seitz
2014-03-21 17:54 ` Joel Brobecker
2014-04-16 21:50 ` Keith Seitz
2014-03-21 19:27 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22TEcAUvoEm2FOe3rbc0AMBfcNCUYd-9vXLTbP1-F1f_8w@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox