From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8791 invoked by alias); 21 Mar 2014 19:27:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8736 invoked by uid 89); 21 Mar 2014 19:27:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ve0-f179.google.com Received: from mail-ve0-f179.google.com (HELO mail-ve0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 21 Mar 2014 19:27:30 +0000 Received: by mail-ve0-f179.google.com with SMTP id db12so3090209veb.10 for ; Fri, 21 Mar 2014 12:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=t6oWOx+DcXWlMU/65X0GVVwo/zs+SggEMgqrS/xhVkA=; b=RGMyr7gM61lFV4gjKl+GwKF+IJng0glry/1keCdmzIwCxynOmclzBgrR66NwmDLwkF A07YxNDFM98k2S45l5C7nOyIHH1lfsQQMpoVPeKVQzAWBbIMmBS/Tx2SQolvrdGOEOx9 fkyi4y6QyLe95c8h/ith4EkXte40xc+fdxQmGn1N2K/iz6qcY1GPqIiYaTScKvlmvIvZ R70R+Lc5+rg1lOmwwYAvTGUbAJDUg+jK3mKcE2SItYvOVer0uSKzgjVxpqpdR73P7XXP d7k+sdP403Y3fz/sweKh36ro5gNsbrpX3VX7bYFMQkYXF+gwciy11K8rPaqNyBHTZwPA tNKw== X-Gm-Message-State: ALoCoQkE0UGvvFx2Kw92KT1JFsmHg0g8LNZTZuSJpG5OYw2QElM4/WX5MBga/zxGxhNmHhPQeBCIrFwlhWS5vbDHJjZQVefFsXN43RPW9W1JwdYtd7dTaUIBQqQzEpzDPtaOWWCrO9vZH0QNsxc1fysgdGPLys7Y/jShuoyjOuxD/OGvdxuJtyzuDoINGnw2jC+ePk4XLkvlu9V/k3xzRuOcma7778hfnA== MIME-Version: 1.0 X-Received: by 10.52.251.199 with SMTP id zm7mr32965927vdc.21.1395430048220; Fri, 21 Mar 2014 12:27:28 -0700 (PDT) Received: by 10.52.13.101 with HTTP; Fri, 21 Mar 2014 12:27:28 -0700 (PDT) In-Reply-To: <20140321171453.GJ4282@adacore.com> References: <532C6D4D.2050705@redhat.com> <20140321171453.GJ4282@adacore.com> Date: Fri, 21 Mar 2014 19:27:00 -0000 Message-ID: Subject: Re: [RFA] Fix gdb/15827 (crash w/corrupt DWARF) From: Doug Evans To: Joel Brobecker Cc: Keith Seitz , "gdb-patches@sourceware.org ml" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00543.txt.bz2 On Fri, Mar 21, 2014 at 10:14 AM, Joel Brobecker wrote: >> +# If we get here and gdb hasn't crashed, the tests pass. >> +pass "corrupt DWARF" > > That's just me but I usually do a "print 1" test, just to make sure > that even if the testing framework did not detect the GDB process > dying, the "print 1" test definitely will. Not important on most, > if not all platforms, but ISTR some odd platforms where this helped. > That's just a suggestion, you don't have to follow it. Not that this needs to be added to this patch, but IWBN to codify this in a utility routine, some tcl proc that does "print 1" or whatever and verifies the expected result. The point is to encapsulate the intent in a suitably named function, verify_gdb_alive or some such.