From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix gdb/15827 (crash w/corrupt DWARF)
Date: Wed, 16 Apr 2014 21:50:00 -0000 [thread overview]
Message-ID: <534EFB2F.1080509@redhat.com> (raw)
In-Reply-To: <20140321175449.GL4282@adacore.com>
On 03/21/2014 10:54 AM, Joel Brobecker wrote:
>> ChangeLog
>> 2014-03-20 Keith Seitz <keiths@redhat.com>
>>
>> PR gdb/15827
>> * dwarf2read.c (skip_one_die): Check that all relative-offset
>> sibling DIEs fall within range of the current reader's buffer.
>> (read_partial_die): Likewise.
>>
>> testsuite/ChangeLog
>> 2014-03-20 Keith Seitz <keiths@redhat.com>
>>
>> PR gdb/15827
>> * gdb.dwarf2/corrupt.c: New file.
>> * gdb.dwarf2/corrupt.exp: New file.
>
> FAOD, this version looks good to me.
>
I don't know why I didn't see this response, but, well, I didn't.
Sorry about the delay -- I've now pushed this patch in.
Thank you for the review.
Keith
next prev parent reply other threads:[~2014-04-16 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 16:48 Keith Seitz
2014-03-21 17:14 ` Joel Brobecker
2014-03-21 17:26 ` Keith Seitz
2014-03-21 17:54 ` Joel Brobecker
2014-04-16 21:50 ` Keith Seitz [this message]
2014-03-21 19:27 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534EFB2F.1080509@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox