From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9254 invoked by alias); 16 Apr 2014 21:50:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9244 invoked by uid 89); 16 Apr 2014 21:50:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Apr 2014 21:50:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3GLoeng004411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Apr 2014 17:50:40 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3GLoddW009998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 16 Apr 2014 17:50:40 -0400 Message-ID: <534EFB2F.1080509@redhat.com> Date: Wed, 16 Apr 2014 21:50:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Fix gdb/15827 (crash w/corrupt DWARF) References: <532C6D4D.2050705@redhat.com> <20140321171453.GJ4282@adacore.com> <532C7624.4080704@redhat.com> <20140321175449.GL4282@adacore.com> In-Reply-To: <20140321175449.GL4282@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00334.txt.bz2 On 03/21/2014 10:54 AM, Joel Brobecker wrote: >> ChangeLog >> 2014-03-20 Keith Seitz >> >> PR gdb/15827 >> * dwarf2read.c (skip_one_die): Check that all relative-offset >> sibling DIEs fall within range of the current reader's buffer. >> (read_partial_die): Likewise. >> >> testsuite/ChangeLog >> 2014-03-20 Keith Seitz >> >> PR gdb/15827 >> * gdb.dwarf2/corrupt.c: New file. >> * gdb.dwarf2/corrupt.exp: New file. > > FAOD, this version looks good to me. > I don't know why I didn't see this response, but, well, I didn't. Sorry about the delay -- I've now pushed this patch in. Thank you for the review. Keith