* PSA: contribution checklist: format of git log entries
@ 2017-02-10 0:16 Doug Evans via gdb-patches
2017-02-10 0:30 ` Doug Evans via gdb-patches
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans via gdb-patches @ 2017-02-10 0:16 UTC (permalink / raw)
To: tromey, gdb-patches
Hi.
I was going to send this earlier but just never got around to it.
I think it was last year, or maybe even longer ago, someone (Gary?)
suggested adding paths to the ChangeLog files in the commit message.
It's fine by me, and it's in the contribution checklist:
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
I think things may have changed a bit as the format that's there now
is slightly different than I remember it. Anyways, it's in the
contribution checklist which I think we're all supposed to follow.
So heads up.
Instead of this:
2017-02-03 Im Dave <im@dave.com>
* foo.c (bar): Fix baz.
2017-02-03 Im Dave <im@dave.com>
* gdb.base/foo.exp: Add new tests.
This:
gdb/ChangeLog:
2017-02-03 Im Dave <im@dave.com>
* foo.c (bar): Fix baz.
gdb/testsuite/ChangeLog:
2017-02-03 Im Dave <im@dave.com>
* gdb.base/foo.exp: Add new tests.
Though lots of people do this in the commit message, which is fine too UUIC.
gdb/ChangeLog:
* foo.c (bar): Fix baz.
gdb/testsuite/ChangeLog:
* gdb.base/foo.exp: Add new tests.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: PSA: contribution checklist: format of git log entries
2017-02-10 0:16 PSA: contribution checklist: format of git log entries Doug Evans via gdb-patches
@ 2017-02-10 0:30 ` Doug Evans via gdb-patches
0 siblings, 0 replies; 2+ messages in thread
From: Doug Evans via gdb-patches @ 2017-02-10 0:30 UTC (permalink / raw)
To: gdb-patches, Tom Tromey
Awesome, total fail in email addresses.
Bleah, sorry.
On Thu, Feb 9, 2017 at 4:15 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> I was going to send this earlier but just never got around to it.
> I think it was last year, or maybe even longer ago, someone (Gary?)
> suggested adding paths to the ChangeLog files in the commit message.
> It's fine by me, and it's in the contribution checklist:
>
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog
>
> I think things may have changed a bit as the format that's there now
> is slightly different than I remember it. Anyways, it's in the
> contribution checklist which I think we're all supposed to follow.
>
> So heads up.
>
> Instead of this:
>
> 2017-02-03 Im Dave <im@dave.com>
>
> * foo.c (bar): Fix baz.
>
> 2017-02-03 Im Dave <im@dave.com>
>
> * gdb.base/foo.exp: Add new tests.
>
> This:
>
> gdb/ChangeLog:
> 2017-02-03 Im Dave <im@dave.com>
>
> * foo.c (bar): Fix baz.
>
> gdb/testsuite/ChangeLog:
> 2017-02-03 Im Dave <im@dave.com>
>
> * gdb.base/foo.exp: Add new tests.
>
> Though lots of people do this in the commit message, which is fine too UUIC.
>
> gdb/ChangeLog:
>
> * foo.c (bar): Fix baz.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/foo.exp: Add new tests.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-10 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 0:16 PSA: contribution checklist: format of git log entries Doug Evans via gdb-patches
2017-02-10 0:30 ` Doug Evans via gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox