From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10434 invoked by alias); 10 Feb 2017 00:30:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10415 invoked by uid 89); 10 Feb 2017 00:30:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=no version=3.3.2 spammy=doug, evans, Doug, Evans X-HELO: mail-it0-f52.google.com Received: from mail-it0-f52.google.com (HELO mail-it0-f52.google.com) (209.85.214.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Feb 2017 00:30:16 +0000 Received: by mail-it0-f52.google.com with SMTP id c7so22211229itd.1 for ; Thu, 09 Feb 2017 16:30:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=YX4UWjZihxMDEsrlOIY8jQGU/NXWKsPR3JfDXrzpC+E=; b=EEV0dNUf0Unk8wwWiSjxSDxscgAk7zUXcvsa7E1CVorW9DqiaSmKURM4DxbaqAKojK f9G7OCBh7dvBFzB5/2rSBsmLQfHWBEVAE9IUQ7DHt5zqQ6SlVCM/RyNjuVKwM+slyocA y8l85h7Fd+lI7Q2J6BNUqdeG6onSVDH2MegEs4KxUyzk9SKvdOTihCu+o0DgeUxDuKHs xsigl0thtk23JBwfTKIY8oaiB7trH17hTZti0BtWG+ZAzQwel5bP9rG2A6Xv3n4mlH78 JVEzzSbejHPu99qcN4biYD/xJM6cPXyL036jgdN0cyAPnbbluDqiRp9p9fi14X1/j8AX VXWA== X-Gm-Message-State: AMke39nNKLmswLOmMf/l6C1UNjqoYd+RRVVtUzv4kpBvQLhmKGmoL8Qo0QKFNSMpSBLeCpW3Xi9nT8pU1dh3qqJQ X-Received: by 10.36.92.132 with SMTP id q126mr5957178itb.108.1486686614167; Thu, 09 Feb 2017 16:30:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.155.17 with HTTP; Thu, 9 Feb 2017 16:29:33 -0800 (PST) In-Reply-To: References: From: "Doug Evans via gdb-patches" Reply-To: Doug Evans Date: Fri, 10 Feb 2017 00:30:00 -0000 Message-ID: Subject: Re: PSA: contribution checklist: format of git log entries To: gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00247.txt.bz2 Awesome, total fail in email addresses. Bleah, sorry. On Thu, Feb 9, 2017 at 4:15 PM, Doug Evans wrote: > Hi. > > I was going to send this earlier but just never got around to it. > I think it was last year, or maybe even longer ago, someone (Gary?) > suggested adding paths to the ChangeLog files in the commit message. > It's fine by me, and it's in the contribution checklist: > > https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog > > I think things may have changed a bit as the format that's there now > is slightly different than I remember it. Anyways, it's in the > contribution checklist which I think we're all supposed to follow. > > So heads up. > > Instead of this: > > 2017-02-03 Im Dave > > * foo.c (bar): Fix baz. > > 2017-02-03 Im Dave > > * gdb.base/foo.exp: Add new tests. > > This: > > gdb/ChangeLog: > 2017-02-03 Im Dave > > * foo.c (bar): Fix baz. > > gdb/testsuite/ChangeLog: > 2017-02-03 Im Dave > > * gdb.base/foo.exp: Add new tests. > > Though lots of people do this in the commit message, which is fine too UUIC. > > gdb/ChangeLog: > > * foo.c (bar): Fix baz. > > gdb/testsuite/ChangeLog: > > * gdb.base/foo.exp: Add new tests.