From: Doug Evans <dje@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
Date: Mon, 24 Jun 2013 18:43:00 -0000 [thread overview]
Message-ID: <CADPb22T+_CC13O9PSR-STBTuCzbf7QE2BHXUPB=9KiFwDKGVvA@mail.gmail.com> (raw)
In-Reply-To: <83sj0al6u1.fsf@gnu.org>
On Sat, Jun 22, 2013 at 4:31 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Wed, 17 Apr 2013 10:25:23 -0700
>> From: Doug Evans <dje@google.com>
>> Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
>>
>> On Wed, Apr 17, 2013 at 10:01 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> Date: Wed, 17 Apr 2013 10:54:10 +0800
>> >> From: Yao Qi <yao@codesourcery.com>
>> >> CC: Eli Zaretskii <eliz@gnu.org>, gdb-patches <gdb-patches@sourceware.org>
>> >>
>> >> The "relocatable" is unclear to me unless I checked configure.ac and
>> >> previous discussions.
>> >
>> > I will add something to explain that, assuming I will find a way to
>> > say that concisely.
>>
>> [for completeness sake]
>> I'd be ok with just adding something to the manual.
>> It would be good to document the fact that a gdb install tree can be
>> moved and gdb will still find its relocatable ancillary files.
>> This goes along with the ability to do "make install DESTDIR=/foo"
>> which is a nice capability.
>
> Is the below OK?
>
> Index: gdb/top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/top.c,v
> retrieving revision 1.236
> diff -u -p -r1.236 top.c
> --- gdb/top.c 30 May 2013 17:27:44 -0000 1.236
> +++ gdb/top.c 22 Jun 2013 11:30:47 -0000
> @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\
> --without-babeltrace\n\
> "));
> #endif
> + fprintf_filtered (stream, _("\n\
> + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\
> +"));
> }
If you want to print something here, then I think you need to take
into account whether "relocatable" is printed at all.
There are lots of places where it may be printed, and each is
conditioned by a macro like FOO_RELOCATABLE.
Taking into account all those macros (and having to maintain the
result over time) seems problematic.
How about just a sentence or two in the manual near the description of
--configuration (or some such).
next prev parent reply other threads:[~2013-06-24 18:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 14:48 Yao Qi
2013-04-12 15:45 ` Eli Zaretskii
2013-04-17 11:02 ` Yao Qi
2013-04-16 1:56 ` Doug Evans
2013-04-16 10:11 ` Eli Zaretskii
2013-04-17 7:40 ` Doug Evans
2013-04-17 9:40 ` Yao Qi
2013-04-17 10:02 ` Doug Evans
2013-04-17 12:54 ` Yao Qi
2013-04-17 22:44 ` Eli Zaretskii
2013-04-18 4:32 ` Doug Evans
2013-06-22 20:03 ` Eli Zaretskii
2013-06-22 22:21 ` Sergio Durigan Junior
2013-06-23 2:21 ` Eli Zaretskii
2013-06-23 2:23 ` Sergio Durigan Junior
2013-06-24 18:43 ` Doug Evans [this message]
2013-06-24 19:03 ` Eli Zaretskii
2013-06-24 19:04 ` Doug Evans
2013-06-24 19:28 ` Eli Zaretskii
2013-06-24 19:33 ` Doug Evans
2013-07-06 7:36 ` Eli Zaretskii
2013-04-17 14:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22T+_CC13O9PSR-STBTuCzbf7QE2BHXUPB=9KiFwDKGVvA@mail.gmail.com' \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox