From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8126 invoked by alias); 24 Jun 2013 18:35:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8115 invoked by uid 89); 24 Jun 2013 18:35:35 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ie0-f181.google.com (HELO mail-ie0-f181.google.com) (209.85.223.181) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 18:35:33 +0000 Received: by mail-ie0-f181.google.com with SMTP id x12so25320161ief.40 for ; Mon, 24 Jun 2013 11:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=MNdAPAPzOIheq5qYKO797Z5VtaR5xrWtAZa5qcEmDoo=; b=GloSvhV4lgH5PbWvRm9kYDDjYSoIsADE+IqIgod0m+vHHWqZlUVtGT6MKj5/PZN+rN 8bsap3MXfs/hCjlbvYhF78l2Ngp/lm1wAlQDW7ABnMveOvCSrSJmEAc0yNoh8fmAZcH6 5eDlIsegsKuzn7yC+kEHZocT7eSaXe0+QKBjIQYA5VGjj2OvgWg01PxDFZXaX5TwWZzO uhMIJPwNiZbn3a2KIoLRVhpTndDtik7al5aSf7f5zlexSb4kWYCGs8C+UJD4AbELmuTV Xhtc7r/Zqir5SrJSgpcV2sitKAGPS9pAW6JieFxFJNVI4XARfP6jlNfltHR8yoUxJu0Z qjZg== MIME-Version: 1.0 X-Received: by 10.42.208.67 with SMTP id gb3mr8811587icb.82.1372098931843; Mon, 24 Jun 2013 11:35:31 -0700 (PDT) Received: by 10.231.143.6 with HTTP; Mon, 24 Jun 2013 11:35:31 -0700 (PDT) In-Reply-To: <83sj0al6u1.fsf@gnu.org> References: <1365761475-23845-1-git-send-email-yao@codesourcery.com> <83fvyr58c5.fsf@gnu.org> <516DEDAD.8070902@codesourcery.com> <516E0ED2.2080203@codesourcery.com> <83obdd2irl.fsf@gnu.org> <83sj0al6u1.fsf@gnu.org> Date: Mon, 24 Jun 2013 18:43:00 -0000 Message-ID: Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration' From: Doug Evans To: Eli Zaretskii Cc: Yao Qi , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlN7zt+OQj8qP0QF886WoRABHPnNIowuresgX/QJAWM4WigxNpQHsZgHSVD0z8oKMdd+vajnQ02vNlkYTtOg6yDp2jBaCshmTJ3aZnmj4+fyskOueRdiHO/SEOlMC0nd0ZSHg6/1p14z734zY20yp67XMfFf0PzRQB92W2RF1m9AZfp+DRiddE1pm/+NuyHx2I/5fIK04/imfmCq5nCDns1y3zfYg== X-SW-Source: 2013-06/txt/msg00666.txt.bz2 On Sat, Jun 22, 2013 at 4:31 AM, Eli Zaretskii wrote: >> Date: Wed, 17 Apr 2013 10:25:23 -0700 >> From: Doug Evans >> Cc: Yao Qi , gdb-patches >> >> On Wed, Apr 17, 2013 at 10:01 AM, Eli Zaretskii wrote: >> >> Date: Wed, 17 Apr 2013 10:54:10 +0800 >> >> From: Yao Qi >> >> CC: Eli Zaretskii , gdb-patches >> >> >> >> The "relocatable" is unclear to me unless I checked configure.ac and >> >> previous discussions. >> > >> > I will add something to explain that, assuming I will find a way to >> > say that concisely. >> >> [for completeness sake] >> I'd be ok with just adding something to the manual. >> It would be good to document the fact that a gdb install tree can be >> moved and gdb will still find its relocatable ancillary files. >> This goes along with the ability to do "make install DESTDIR=/foo" >> which is a nice capability. > > Is the below OK? > > Index: gdb/top.c > =================================================================== > RCS file: /cvs/src/src/gdb/top.c,v > retrieving revision 1.236 > diff -u -p -r1.236 top.c > --- gdb/top.c 30 May 2013 17:27:44 -0000 1.236 > +++ gdb/top.c 22 Jun 2013 11:30:47 -0000 > @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\ > --without-babeltrace\n\ > ")); > #endif > + fprintf_filtered (stream, _("\n\ > + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\ > +")); > } If you want to print something here, then I think you need to take into account whether "relocatable" is printed at all. There are lots of places where it may be printed, and each is conditioned by a macro like FOO_RELOCATABLE. Taking into account all those macros (and having to maintain the result over time) seems problematic. How about just a sentence or two in the manual near the description of --configuration (or some such).