From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>, Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
Date: Tue, 16 Apr 2013 01:56:00 -0000 [thread overview]
Message-ID: <CADPb22RPtCiBOg8o6M1vKXJxGeDcTOriact4ujojygskBnrFFQ@mail.gmail.com> (raw)
In-Reply-To: <1365761475-23845-1-git-send-email-yao@codesourcery.com>
On Fri, Apr 12, 2013 at 3:11 AM, Yao Qi <yao@codesourcery.com> wrote:
> The recent committed CTF patch introduces a new configure option
> '--with-babeltrace'. This patch is to print the configure choice
> in 'gdb --configuration'. Is it OK?
>
> gdb:
>
> 2013-04-12 Yao Qi <yao@codesourcery.com>
>
> * top.c (print_gdb_configuration): Print configure-time
> parameter on using libbabeltrace or not.
> ---
> gdb/top.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/top.c b/gdb/top.c
> index 6a402ba..480b67e 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1242,6 +1242,15 @@ This GDB was configured as follows:\n\
> --without-zlib\n\
> "));
> #endif
> +#if HAVE_LIBBABELTRACE
> + fprintf_filtered (stream, _("\
> + --with-babeltrace\n\
> +"));
> +#else
> + fprintf_filtered (stream, _("\
> + --without-babeltrace\n\
> +"));
> +#endif
> }
Do we care about printing --with-libbabeltrace-prefix?
I don't have a strong preference, but if we're going to go down this
path I think we should.
[An alternative would be to punt on details at this level and instead
record the complete string passed to configure and print that.]
next prev parent reply other threads:[~2013-04-15 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 14:48 Yao Qi
2013-04-12 15:45 ` Eli Zaretskii
2013-04-17 11:02 ` Yao Qi
2013-04-16 1:56 ` Doug Evans [this message]
2013-04-16 10:11 ` Eli Zaretskii
2013-04-17 7:40 ` Doug Evans
2013-04-17 9:40 ` Yao Qi
2013-04-17 10:02 ` Doug Evans
2013-04-17 12:54 ` Yao Qi
2013-04-17 22:44 ` Eli Zaretskii
2013-04-18 4:32 ` Doug Evans
2013-06-22 20:03 ` Eli Zaretskii
2013-06-22 22:21 ` Sergio Durigan Junior
2013-06-23 2:21 ` Eli Zaretskii
2013-06-23 2:23 ` Sergio Durigan Junior
2013-06-24 18:43 ` Doug Evans
2013-06-24 19:03 ` Eli Zaretskii
2013-06-24 19:04 ` Doug Evans
2013-06-24 19:28 ` Eli Zaretskii
2013-06-24 19:33 ` Doug Evans
2013-07-06 7:36 ` Eli Zaretskii
2013-04-17 14:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22RPtCiBOg8o6M1vKXJxGeDcTOriact4ujojygskBnrFFQ@mail.gmail.com \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox