From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13464 invoked by alias); 15 Apr 2013 18:51:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13454 invoked by uid 89); 15 Apr 2013 18:51:16 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-ve0-f179.google.com (HELO mail-ve0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Apr 2013 18:50:53 +0000 Received: by mail-ve0-f179.google.com with SMTP id oz10so1277466veb.24 for ; Mon, 15 Apr 2013 11:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=JnVQJk79KJn4DrmNL9ys/SstRFyLlcJg9oXPRojly1I=; b=QNHCnIGwkkfsLEhIhSvi92SjiiUbKWy6tvjj9CIznvviQk7V9ROZE/zujn/Mov4kgp BeX9C1Iz1pODxqnaEmSYfujdr61F46cYwtUDl4LgufUslhv2QJNCGl7uKWRVAhGiIGWK cjV/ZbSupjkLDhvYJZMve90MAhigAFmwmjzyW7BowN18TmVEOOVNoLgfnq6sJIVWdpRU VaqsiIegiz0rHE4ZjZo7vM7zHL4a2QDASsQA8NfG0HOgo+1FeUP1NVcpqhlJj4a5gmTr PBZ3uDsKfAfrWo08kNGXnh4vVGXgBbwNTZ0soGJrpWO56kgWbk3lWxkacAH833CGudeL Ihcw== MIME-Version: 1.0 X-Received: by 10.52.17.196 with SMTP id q4mr3043417vdd.63.1366051851351; Mon, 15 Apr 2013 11:50:51 -0700 (PDT) Received: by 10.220.123.70 with HTTP; Mon, 15 Apr 2013 11:50:51 -0700 (PDT) In-Reply-To: <1365761475-23845-1-git-send-email-yao@codesourcery.com> References: <1365761475-23845-1-git-send-email-yao@codesourcery.com> Date: Tue, 16 Apr 2013 01:56:00 -0000 Message-ID: Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration' From: Doug Evans To: Yao Qi , Eli Zaretskii Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQllvHaB0mQXm4ZRCehdx2Ph5181W8AwQeCxv8ez3DahwaaH6f1UPvFaBU4NvEam+488lFW9QhDeQuHqG7VNb3Vsl+wPKJ9lw/va+Ps6WdEvoyfEnS0Jtuar45pJSrGptFYfrGFXi/adqV0nZyQE3Y3mw3b8keXNmGLw8KjAJw7Wpkjxfv5RvNfYMgV9xy+NWy/AooKlWJdrZFIQ5xXWqIhOAroIrA== X-SW-Source: 2013-04/txt/msg00441.txt.bz2 On Fri, Apr 12, 2013 at 3:11 AM, Yao Qi wrote: > The recent committed CTF patch introduces a new configure option > '--with-babeltrace'. This patch is to print the configure choice > in 'gdb --configuration'. Is it OK? > > gdb: > > 2013-04-12 Yao Qi > > * top.c (print_gdb_configuration): Print configure-time > parameter on using libbabeltrace or not. > --- > gdb/top.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/gdb/top.c b/gdb/top.c > index 6a402ba..480b67e 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -1242,6 +1242,15 @@ This GDB was configured as follows:\n\ > --without-zlib\n\ > ")); > #endif > +#if HAVE_LIBBABELTRACE > + fprintf_filtered (stream, _("\ > + --with-babeltrace\n\ > +")); > +#else > + fprintf_filtered (stream, _("\ > + --without-babeltrace\n\ > +")); > +#endif > } Do we care about printing --with-libbabeltrace-prefix? I don't have a strong preference, but if we're going to go down this path I think we should. [An alternative would be to punt on details at this level and instead record the complete string passed to configure and print that.]