Re: [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug}

[Doug Evans <dje@google.com>]

Hi.  twas away for awhile and didn't see the patch.

Potentially, but some questions first:

1) How common/useful would it be to distinguish shared libs of an app
I've just built and installed in some private dir (or maybe
/usr/local) from system shared libs?
IOW treating, e.g., files in $HOME/lib/mumble different from /usr/lib/mumble.
I'm not sure it's a useful distinction, just wondering.

2) How do you see {with,without}-separate-debuginfo being used in practice?
I'm just wondering if this choice is the core of the problem or
whether it's system vs non-system.

[I understand the reasoning behind the previous version of the patch,
it's a problem that I as a distro user would want solved.
with-separate-debuginfo is a good proxy for system files, it's just
not good enough  for me.  Sorry!]

On Wed, Feb 27, 2013 at 10:53 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi Doug,
>
> do you consider the new 2 patch parts address your original concern?
>
> [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug}
> http://sourceware.org/ml/gdb-patches/2013-02/msg00413.html
> Message-ID: <20130215202536.GA20435@host2.jankratochvil.net>
>
> [patch+doc 2/2] filename-display: default *-sepdebug to absolute
> http://sourceware.org/ml/gdb-patches/2013-02/msg00414.html
> Message-ID: <20130215202613.GB20435@host2.jankratochvil.net>
>
>
> Thanks,
> Jan
>
> ------------------------------------------------------------------------------
>
> On Fri, 15 Feb 2013 21:25:36 +0100, Jan Kratochvil wrote:
> Hi,
>
> this mail obsoletes:
>         [patchv2 12/11] New options {relative,basename}-with-system-absolute
>         http://sourceware.org/ml/gdb-patches/2013-01/msg00700.html
>         Message-ID: <20130129221019.GA27463@host2.jankratochvil.net>
>
> to address Doug's argument
>         http://sourceware.org/ml/gdb-patches/2013-02/msg00193.html
>         Message-ID: <CADPb22TatUwO6qL6sJEr8HRhjJR_Q66de7zhFdLA81hToNuJjA@mail.gmail.com>
>         > "system" is being conflated with "separate debug info", and I'm not
>         > comfortable with that.
>
> In the patch below I had optimization of "show filename-display" to display a
> single line if all the 4 options were set to the same value.
>         (gdb) show filename-display
>         Filenames are displayed as "relative".
> But later I found it rather confusing and despite one can type:
>         (gdb) set filename-display relative
> GDB will then still display now explicitly:
>         (gdb) show filename-display
>         executable:  Filenames in executable with embedded debug info are displayed as "relative".
>         executable-with-separate-debug-info:  Filenames in executable with separate debug info are displayed as "relative".
>         libraries:  Filenames in shared libraries with embedded debug info are displayed as "relative".
>         libraries-with-separate-debug-info:  Filenames in shared libraries with separate debug info are displayed as "relative".
> I can return the single-line display back if anyone thinks so.
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora19pre-linux-gnu.
>
>
> Thanks,
> Jan
>
>
> gdb/
> 2013-02-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         * NEWS (set filename-display executable)
>         (set filename-display libraries)
>         (set filename-display executable-with-separate-debug-info)
>         (set filename-display libraries-with-separate-debug-info)
>         (show filename-display executable)
>         (show filename-display libraries)
>         (show filename-display executable-with-separate-debug-info)
>         (show filename-display libraries-with-separate-debug-info): New.  Also
>         say for all the options.
>         * source.c: Include cli/cli-decode.h and cli/cli-setshow.h.
>         (filename_display_string): Remove.
>         (filename_display_executable_string)
>         (filename_display_libraries_string)
>         (filename_display_executable_sepdebug_string)
>         (filename_display_libraries_sepdebug_string): New.
>         (show_filename_display_string): Remove.
>         (show_filename_display_executable_string)
>         (show_filename_display_libraries_string)
>         (show_filename_display_executable_sepdebug_string)
>         (show_filename_display_libraries_sepdebug_string): New.
>         (symtab_to_filename_for_display): Follow the new variables.
>         (filename_display_set_cmdlist, filename_display_show_cmdlist)
>         (set_filename_display_cmd, set_filename_display_1)
>         (set_filename_display_basename_string)
>         (set_filename_display_relative_string)
>         (set_filename_display_absolute_string, show_filename_display_cmd): New.
>         (_initialize_source): New variables filename_display_doc and doc.
>         Initialize filename_display_doc.  Remove add_setshow_enum_cmd for
>         filename-display.  Add filename_display_set_cmdlist and
>         filename_display_show_cmdlist initializations by add_prefix_cmd.
>         Add add_setshow_enum_cmd for executable, libraries,
>         executable-with-separate-debug-info and
>         libraries-with-separate-debug-info.  Add add_cmd for basename, relative
>         and absolute.
>
> gdb/doc/
> 2013-02-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         * gdb.texinfo (Backtrace): Extend the show filename-display description.
>         New description for set filename-display executable, set
>         filename-display libraries, set filename-display
>         executable-with-separate-debug-info, set filename-display
>         libraries-with-separate-debug-info, show filename-display executable,
>         show filename-display libraries, show filename-display
>         executable-with-separate-debug-info and show filename-display
>         libraries-with-separate-debug-info.
>         (Files): New anchor file command.