From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21909 invoked by alias); 27 Feb 2013 19:40:20 -0000 Received: (qmail 21825 invoked by uid 22791); 27 Feb 2013 19:40:19 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-wg0-f44.google.com (HELO mail-wg0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 19:40:09 +0000 Received: by mail-wg0-f44.google.com with SMTP id dr12so771759wgb.23 for ; Wed, 27 Feb 2013 11:40:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=QVQXPKvHRb6MfqmIc5QO8gNGcHY/Ii/zleGDvdG6Fsc=; b=DxGQlGzsqKvJt01gnGxGiguEbQpQQiA9H1xudYiS4YM8qNzW0TPj0uvU8OGcVT4MK3 MfmC7WjvbEw/Yh71arQtsCLXHt32JroTH11le5+SsbX02YIKlHTXtw1Obgdrr1UliZss RxmJQLb+drAxv4hGRn/KvnkF19lr9sPM5RBM16QRjaMGBqib1GvQIeYcB2jdLy2lE/oj utEc/cwWw7lnREd0o0ltDtiIWRvN9oj6K4BF50QfvqX5x5gQbfnAxkp+0I7bFa7Uy8us fQilS3kjLhCzj7sEtsEwel0DBNvTg1he9kK89BJxwcnosneb+1jGQVN03ID8dz1KmL7g s8pw== MIME-Version: 1.0 X-Received: by 10.181.12.5 with SMTP id em5mr6104065wid.24.1361994008256; Wed, 27 Feb 2013 11:40:08 -0800 (PST) Received: by 10.194.78.37 with HTTP; Wed, 27 Feb 2013 11:40:08 -0800 (PST) In-Reply-To: <20130227185345.GA21375@host2.jankratochvil.net> References: <20130215202536.GA20435@host2.jankratochvil.net> <20130227185345.GA21375@host2.jankratochvil.net> Date: Wed, 27 Feb 2013 19:50:00 -0000 Message-ID: Subject: Re: [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug} From: Doug Evans To: Jan Kratochvil Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkFABrEwLCHDImq4eUh5zMwIt7dolMCMsy5t6PBjMGqJHEhZ6MxEGa5inLO36U4IxQ5CeaJae0mdVOAdDs8WLQ+zFE8Y8JnP8fU3kvXfnkG+Z0+j7eJFFOTxK+P6xp5UBFu5242UBR9UqEuUDiBiKeq1+Hv2dCh6cMTRh5h0Z9P1/I+RsqcSJ4jUb425+Aaw7OnAsm4P7VKRVvy9Puj/2A3SokpvQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00706.txt.bz2 Hi. twas away for awhile and didn't see the patch. Potentially, but some questions first: 1) How common/useful would it be to distinguish shared libs of an app I've just built and installed in some private dir (or maybe /usr/local) from system shared libs? IOW treating, e.g., files in $HOME/lib/mumble different from /usr/lib/mumble. I'm not sure it's a useful distinction, just wondering. 2) How do you see {with,without}-separate-debuginfo being used in practice? I'm just wondering if this choice is the core of the problem or whether it's system vs non-system. [I understand the reasoning behind the previous version of the patch, it's a problem that I as a distro user would want solved. with-separate-debuginfo is a good proxy for system files, it's just not good enough for me. Sorry!] On Wed, Feb 27, 2013 at 10:53 AM, Jan Kratochvil wrote: > Hi Doug, > > do you consider the new 2 patch parts address your original concern? > > [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug} > http://sourceware.org/ml/gdb-patches/2013-02/msg00413.html > Message-ID: <20130215202536.GA20435@host2.jankratochvil.net> > > [patch+doc 2/2] filename-display: default *-sepdebug to absolute > http://sourceware.org/ml/gdb-patches/2013-02/msg00414.html > Message-ID: <20130215202613.GB20435@host2.jankratochvil.net> > > > Thanks, > Jan > > ------------------------------------------------------------------------------ > > On Fri, 15 Feb 2013 21:25:36 +0100, Jan Kratochvil wrote: > Hi, > > this mail obsoletes: > [patchv2 12/11] New options {relative,basename}-with-system-absolute > http://sourceware.org/ml/gdb-patches/2013-01/msg00700.html > Message-ID: <20130129221019.GA27463@host2.jankratochvil.net> > > to address Doug's argument > http://sourceware.org/ml/gdb-patches/2013-02/msg00193.html > Message-ID: > > "system" is being conflated with "separate debug info", and I'm not > > comfortable with that. > > In the patch below I had optimization of "show filename-display" to display a > single line if all the 4 options were set to the same value. > (gdb) show filename-display > Filenames are displayed as "relative". > But later I found it rather confusing and despite one can type: > (gdb) set filename-display relative > GDB will then still display now explicitly: > (gdb) show filename-display > executable: Filenames in executable with embedded debug info are displayed as "relative". > executable-with-separate-debug-info: Filenames in executable with separate debug info are displayed as "relative". > libraries: Filenames in shared libraries with embedded debug info are displayed as "relative". > libraries-with-separate-debug-info: Filenames in shared libraries with separate debug info are displayed as "relative". > I can return the single-line display back if anyone thinks so. > > No regressions on {x86_64,x86_64-m32,i686}-fedora19pre-linux-gnu. > > > Thanks, > Jan > > > gdb/ > 2013-02-15 Jan Kratochvil > > * NEWS (set filename-display executable) > (set filename-display libraries) > (set filename-display executable-with-separate-debug-info) > (set filename-display libraries-with-separate-debug-info) > (show filename-display executable) > (show filename-display libraries) > (show filename-display executable-with-separate-debug-info) > (show filename-display libraries-with-separate-debug-info): New. Also > say for all the options. > * source.c: Include cli/cli-decode.h and cli/cli-setshow.h. > (filename_display_string): Remove. > (filename_display_executable_string) > (filename_display_libraries_string) > (filename_display_executable_sepdebug_string) > (filename_display_libraries_sepdebug_string): New. > (show_filename_display_string): Remove. > (show_filename_display_executable_string) > (show_filename_display_libraries_string) > (show_filename_display_executable_sepdebug_string) > (show_filename_display_libraries_sepdebug_string): New. > (symtab_to_filename_for_display): Follow the new variables. > (filename_display_set_cmdlist, filename_display_show_cmdlist) > (set_filename_display_cmd, set_filename_display_1) > (set_filename_display_basename_string) > (set_filename_display_relative_string) > (set_filename_display_absolute_string, show_filename_display_cmd): New. > (_initialize_source): New variables filename_display_doc and doc. > Initialize filename_display_doc. Remove add_setshow_enum_cmd for > filename-display. Add filename_display_set_cmdlist and > filename_display_show_cmdlist initializations by add_prefix_cmd. > Add add_setshow_enum_cmd for executable, libraries, > executable-with-separate-debug-info and > libraries-with-separate-debug-info. Add add_cmd for basename, relative > and absolute. > > gdb/doc/ > 2013-02-15 Jan Kratochvil > > * gdb.texinfo (Backtrace): Extend the show filename-display description. > New description for set filename-display executable, set > filename-display libraries, set filename-display > executable-with-separate-debug-info, set filename-display > libraries-with-separate-debug-info, show filename-display executable, > show filename-display libraries, show filename-display > executable-with-separate-debug-info and show filename-display > libraries-with-separate-debug-info. > (Files): New anchor file command.