Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug}
Date: Sat, 16 Feb 2013 08:33:00 -0000	[thread overview]
Message-ID: <83ehggslp9.fsf@gnu.org> (raw)
In-Reply-To: <20130215202536.GA20435@host2.jankratochvil.net>

> Date: Fri, 15 Feb 2013 21:25:36 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -123,9 +123,20 @@ show print type typedefs
>    The default is to show them.
>  
>  set filename-display basename|relative|absolute
> +set filename-display executable basename|relative|absolute
> +set filename-display libraries basename|relative|absolute
> +set filename-display executable-with-separate-debug-info basename|relative
> +							 |absolute
> +set filename-display libraries-with-separate-debug-info basename|relative
> +							|absolute
>  show filename-display
> +show filename-display executable
> +show filename-display libraries
> +show filename-display executable-with-separate-debug-info
> +show filename-display libraries-with-separate-debug-info
>    Control the way in which filenames is displayed.
> -  The default is "relative", which preserves previous behavior.
> +  The default is "relative" for all the options, which preserves previous
> +  behavior.

OK for this part.

> +@item set filename-display executable @{relative|basename|absolute@}
> +Set how to display filenames coming from the inferior executable, as set by the
> +@ref{file command}.  Inferior executable has to use embedded debug info as is
> +usually found in binaries compiled by @value{GDBN} user.

Here and elsewhere, I think, instead of a separate sentence saying "FOO
has to use BAR debug info", it is better to say "... when FOO uses BAR
debug info" in the same sentence.  For example:

  Set how to display filenames coming from the inferior executable, as
  set by the @ref{file command}, when the inferior executable uses
  embedded debug info as found in binaries compiled normally.

Otherwise, OK.

Thanks.


  reply	other threads:[~2013-02-16  8:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 20:25 Jan Kratochvil
2013-02-16  8:33 ` Eli Zaretskii [this message]
2013-02-18 14:33   ` Jan Kratochvil
2013-02-18 16:27     ` Eli Zaretskii
2013-02-27 19:38 ` Jan Kratochvil
2013-02-27 19:50   ` Doug Evans
2013-02-27 20:06     ` Jan Kratochvil
2013-03-06 19:54       ` Doug Evans
2013-03-07  9:52         ` Jan Kratochvil
2013-03-07 10:26           ` Pedro Alves
2013-03-07 12:01             ` Jan Kratochvil
2013-03-07 10:30         ` Pedro Alves
2013-03-07 12:04           ` Jan Kratochvil
2013-03-07 13:36             ` Pedro Alves
2013-03-07 15:07               ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ehggslp9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox