From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98583-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18178 invoked by alias); 16 Feb 2013 08:33:33 -0000
Received: (qmail 18141 invoked by uid 22791); 16 Feb 2013 08:33:31 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Feb 2013 08:33:23 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MIB00L000Y6R600@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 16 Feb 2013 10:32:32 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MIB00LFS128S200@a-mtaout20.012.net.il>; Sat, 16 Feb 2013 10:32:32 +0200 (IST)
Date: Sat, 16 Feb 2013 08:33:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch+doc 1/2] filename-display: 1->4 options {inferior,libs}{,-sepdebug}
In-reply-to: <20130215202536.GA20435@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83ehggslp9.fsf@gnu.org>
References: <20130215202536.GA20435@host2.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00433.txt.bz2

> Date: Fri, 15 Feb 2013 21:25:36 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -123,9 +123,20 @@ show print type typedefs
>    The default is to show them.
>  
>  set filename-display basename|relative|absolute
> +set filename-display executable basename|relative|absolute
> +set filename-display libraries basename|relative|absolute
> +set filename-display executable-with-separate-debug-info basename|relative
> +							 |absolute
> +set filename-display libraries-with-separate-debug-info basename|relative
> +							|absolute
>  show filename-display
> +show filename-display executable
> +show filename-display libraries
> +show filename-display executable-with-separate-debug-info
> +show filename-display libraries-with-separate-debug-info
>    Control the way in which filenames is displayed.
> -  The default is "relative", which preserves previous behavior.
> +  The default is "relative" for all the options, which preserves previous
> +  behavior.

OK for this part.

> +@item set filename-display executable @{relative|basename|absolute@}
> +Set how to display filenames coming from the inferior executable, as set by the
> +@ref{file command}.  Inferior executable has to use embedded debug info as is
> +usually found in binaries compiled by @value{GDBN} user.

Here and elsewhere, I think, instead of a separate sentence saying "FOO
has to use BAR debug info", it is better to say "... when FOO uses BAR
debug info" in the same sentence.  For example:

  Set how to display filenames coming from the inferior executable, as
  set by the @ref{file command}, when the inferior executable uses
  embedded debug info as found in binaries compiled normally.

Otherwise, OK.

Thanks.