Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Vasyl Vavrychuk <vvavrychuk@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
Date: Mon, 17 Sep 2012 15:40:00 -0000	[thread overview]
Message-ID: <CADPb22StZm5T_ULmQkqZO6ny1hkZM_oX0XrqxSOzqS=VM+tJ6Q@mail.gmail.com> (raw)
In-Reply-To: <20120917152938.GA22356@host2.jankratochvil.net>

On Mon, Sep 17, 2012 at 8:29 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> gdb/
> 2012-09-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>         Fix internal error on canonicalization of clang types.
>         * cp-name-parser.y (exp): Use "sizeof ".
>
>
> diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
> index 6767fa5..c57ce64 100644
> --- a/gdb/cp-name-parser.y
> +++ b/gdb/cp-name-parser.y
> @@ -1183,7 +1183,7 @@ exp       :       FLOAT
>         ;
>
>  exp    :       SIZEOF '(' type ')'     %prec UNARY
> -               { $$ = d_unary ("sizeof", $3); }
> +               { $$ = d_unary ("sizeof ", $3); }
>         ;
>
>  /* C++.  */

I had to look hard to see the change here.
Comment explaining "why things are they way they are" is required IMO.
[I'm assuming the above change is in fact TRTTD.]


  reply	other threads:[~2012-09-17 15:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGj4m+4au-jiC2ueSyC+wEY76YRQ5zNuxfY+-mfZ39N4fnpN_g@mail.gmail.com>
     [not found] ` <20120916080035.GA28890@host2.jankratochvil.net>
     [not found]   ` <CAGj4m+46oBXSYQ-wx9g-P7yevZeMDnNNEjvADE8sRSdoWaRiVA@mail.gmail.com>
2012-09-17  6:27     ` [patch] Fix internal error on canonicalization of clang types [Re: why in cplus_demangle_operators operation sizeof is expected to be followed with space] Jan Kratochvil
2012-09-17  8:29       ` Vasyl Vavrychuk
2012-09-17 15:30         ` [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch) Jan Kratochvil
2012-09-17 15:40           ` Doug Evans [this message]
2012-09-17 16:13             ` Jan Kratochvil
2012-09-17 19:52               ` Tom Tromey
2012-09-21 19:36                 ` Jan Kratochvil
2012-09-21 19:40                   ` Tom Tromey
2012-09-21 19:52                     ` Jan Kratochvil
2012-09-21 19:57                       ` Tom Tromey
2012-09-21 20:01                         ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22StZm5T_ULmQkqZO6ny1hkZM_oX0XrqxSOzqS=VM+tJ6Q@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=vvavrychuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox