From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22384 invoked by alias); 17 Sep 2012 15:40:16 -0000 Received: (qmail 22372 invoked by uid 22791); 17 Sep 2012 15:40:15 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 15:40:01 +0000 Received: by vbkv13 with SMTP id v13so8760426vbk.0 for ; Mon, 17 Sep 2012 08:40:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=2crbuyvs9Y20lEdeqY/67KFiXAJ0rDBmdeLmscubOao=; b=VdjQoRIPtl8/6ZmNui51knkhqghZHuoXE5qhSKOc1GDoc8lNYwxvrhWN8/jHMs1+lj A8txP+Iv+167gXzRh9itkOpOCgJAxH9y1v2j71IJUtAD1q5OhYb9g684/BpGb4m/gdSU rJIuZK7pVeBxIjgF/E7uoOJVzSvXn4rws8tlbrfdRFsc0E5ER43D2/6WnIS6zZn5bYjN QgJpdSlj2J3F7Tc5XeBkpcIAPyV6SkSw2RhZeuE1O7F3BUgQiH5Q0VtsOAVPObDYHbWV s33s8QHaIi0h7i1yYiHDIbmwWbLydxcwS6Ay3GKcI7fOeH47INKuuj6lW93LWv+ukIUu kGzw== Received: by 10.220.221.193 with SMTP id id1mr664723vcb.8.1347896400475; Mon, 17 Sep 2012 08:40:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.221.193 with SMTP id id1mr664707vcb.8.1347896400212; Mon, 17 Sep 2012 08:40:00 -0700 (PDT) Received: by 10.52.24.239 with HTTP; Mon, 17 Sep 2012 08:40:00 -0700 (PDT) In-Reply-To: <20120917152938.GA22356@host2.jankratochvil.net> References: <20120916080035.GA28890@host2.jankratochvil.net> <20120917062647.GA2514@host2.jankratochvil.net> <20120917152938.GA22356@host2.jankratochvil.net> Date: Mon, 17 Sep 2012 15:40:00 -0000 Message-ID: Subject: Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch) From: Doug Evans To: Jan Kratochvil Cc: Vasyl Vavrychuk , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQk0voB1CfFbng2my9T+9QJmC5Gg8cL+ZnmnNn4jFmlNVkpRxX53hd78Hxux0ujHcHbTvPimkJ2ouqqRXVqfaWw1V0I8MHHgVcjAExFGftf2JLu/knxI1Tikb/Eqa4e5HcPU9cp8LRrX5IVREPCALyYBp8lm6xVA5wbEB3SrFk2KJQvycp8K5PIEgWfXEgXl16JvUiOv7psHZNLRq3+maL4YLH2XDA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00315.txt.bz2 On Mon, Sep 17, 2012 at 8:29 AM, Jan Kratochvil wrote: > gdb/ > 2012-09-17 Jan Kratochvil > > Fix internal error on canonicalization of clang types. > * cp-name-parser.y (exp): Use "sizeof ". > > > diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y > index 6767fa5..c57ce64 100644 > --- a/gdb/cp-name-parser.y > +++ b/gdb/cp-name-parser.y > @@ -1183,7 +1183,7 @@ exp : FLOAT > ; > > exp : SIZEOF '(' type ')' %prec UNARY > - { $$ = d_unary ("sizeof", $3); } > + { $$ = d_unary ("sizeof ", $3); } > ; > > /* C++. */ I had to look hard to see the change here. Comment explaining "why things are they way they are" is required IMO. [I'm assuming the above change is in fact TRTTD.]