From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Doug Evans <dje@google.com>,
Vasyl Vavrychuk <vvavrychuk@gmail.com>,
gdb-patches@sourceware.org
Subject: Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch)
Date: Fri, 21 Sep 2012 19:52:00 -0000 [thread overview]
Message-ID: <20120921195142.GA2465@host2.jankratochvil.net> (raw)
In-Reply-To: <87k3vnrwqd.fsf@fleche.redhat.com>
On Fri, 21 Sep 2012 21:39:54 +0200, Tom Tromey wrote:
> At least from the patch it appears that the comment is over by the
> leftmost column, but I think the comment should be indented like the
> code is.
This is after patch from the mail, grep -3 xxx | expand, inserted into this
mail.
I see it has 81 columns but with the large tabs there this file has very
common violation of > 80 columns; I can fix this patch, though.
Thanks,
Jan
------------------------------------------------------------------------------
operator : OPERATOR NEW
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("new", 3);
}
| OPERATOR DELETE
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("delete ", 1);
}
| OPERATOR NEW '[' ']'
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("new[]", 3);
}
| OPERATOR DELETE '[' ']'
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = make_operator ("delete[] ", 1);
}
--
exp : SIZEOF '(' type ')' %prec UNARY
{
/* Match the whitespacing of cplus_demangle_operators.
It would abort on unrecognized string otherwise. */
$$ = d_unary ("sizeof ", $3);
}
next prev parent reply other threads:[~2012-09-21 19:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGj4m+4au-jiC2ueSyC+wEY76YRQ5zNuxfY+-mfZ39N4fnpN_g@mail.gmail.com>
[not found] ` <20120916080035.GA28890@host2.jankratochvil.net>
[not found] ` <CAGj4m+46oBXSYQ-wx9g-P7yevZeMDnNNEjvADE8sRSdoWaRiVA@mail.gmail.com>
2012-09-17 6:27 ` [patch] Fix internal error on canonicalization of clang types [Re: why in cplus_demangle_operators operation sizeof is expected to be followed with space] Jan Kratochvil
2012-09-17 8:29 ` Vasyl Vavrychuk
2012-09-17 15:30 ` [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch) Jan Kratochvil
2012-09-17 15:40 ` Doug Evans
2012-09-17 16:13 ` Jan Kratochvil
2012-09-17 19:52 ` Tom Tromey
2012-09-21 19:36 ` Jan Kratochvil
2012-09-21 19:40 ` Tom Tromey
2012-09-21 19:52 ` Jan Kratochvil [this message]
2012-09-21 19:57 ` Tom Tromey
2012-09-21 20:01 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921195142.GA2465@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=vvavrychuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox