From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2233 invoked by alias); 21 Sep 2012 19:52:07 -0000 Received: (qmail 2223 invoked by uid 22791); 21 Sep 2012 19:52:06 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Sep 2012 19:51:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LJplfI024752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Sep 2012 15:51:48 -0400 Received: from host2.jankratochvil.net (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8LJphOJ001777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 21 Sep 2012 15:51:46 -0400 Date: Fri, 21 Sep 2012 19:52:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: Doug Evans , Vasyl Vavrychuk , gdb-patches@sourceware.org Subject: Re: [patch] Fix internal error on canonicalization of clang types (+lib/gdb.exp internal error catch) Message-ID: <20120921195142.GA2465@host2.jankratochvil.net> References: <20120916080035.GA28890@host2.jankratochvil.net> <20120917062647.GA2514@host2.jankratochvil.net> <20120917152938.GA22356@host2.jankratochvil.net> <20120917161252.GA24333@host2.jankratochvil.net> <87y5k8xw9j.fsf@fleche.redhat.com> <20120921193623.GB27473@host2.jankratochvil.net> <87k3vnrwqd.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k3vnrwqd.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00460.txt.bz2 On Fri, 21 Sep 2012 21:39:54 +0200, Tom Tromey wrote: > At least from the patch it appears that the comment is over by the > leftmost column, but I think the comment should be indented like the > code is. This is after patch from the mail, grep -3 xxx | expand, inserted into this mail. I see it has 81 columns but with the large tabs there this file has very common violation of > 80 columns; I can fix this patch, though. Thanks, Jan ------------------------------------------------------------------------------ operator : OPERATOR NEW { /* Match the whitespacing of cplus_demangle_operators. It would abort on unrecognized string otherwise. */ $$ = make_operator ("new", 3); } | OPERATOR DELETE { /* Match the whitespacing of cplus_demangle_operators. It would abort on unrecognized string otherwise. */ $$ = make_operator ("delete ", 1); } | OPERATOR NEW '[' ']' { /* Match the whitespacing of cplus_demangle_operators. It would abort on unrecognized string otherwise. */ $$ = make_operator ("new[]", 3); } | OPERATOR DELETE '[' ']' { /* Match the whitespacing of cplus_demangle_operators. It would abort on unrecognized string otherwise. */ $$ = make_operator ("delete[] ", 1); } -- exp : SIZEOF '(' type ')' %prec UNARY { /* Match the whitespacing of cplus_demangle_operators. It would abort on unrecognized string otherwise. */ $$ = d_unary ("sizeof ", $3); }