From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] gdb_assert -> complaint for weird DWARF
Date: Mon, 24 Feb 2014 22:59:00 -0000 [thread overview]
Message-ID: <CADPb22SWQMhT0VQ=ryAQd_a4LNMTeGfke+qcgwewxaS3_qQKAg@mail.gmail.com> (raw)
In-Reply-To: <20140224220439.GA7121@host2.jankratochvil.net>
On Mon, Feb 24, 2014 at 2:04 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi Doug,
>
> On Mon, 24 Feb 2014 22:55:49 +0100, Doug Evans wrote:
>> Can you dig into the details of why the assert is tripping?
>> I'm not comfortable with adding more complaints without at least
>> including documentation of details.
>
> I have filed the Fedora GCC bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1069382
>
> This is all I can do now. My build of FSF GCC does not upset GDB.
>
> I agree the current situation is not great, IMO there is a gnat DWARF
> generator bug.
Can you send me the binaries for repro?
I see in the above bug report an abstract_origin which is what the
patch has specific code for to avoid tripping the assert.
We could probably generate a good testcase for gdb from that.
Another worry I have is that if my expectation that we shouldn't be
recursively calling process_die (even for bad debug info) is wrong,
then is there some obscure case where possible accidental re-reading
of a DIE is actually needed by the current code to get the right
answer (IOW is making this a complaint and returning also introducing
a bug? Less of a bug than crashing or infinite recursion of course,
but IWBN to invest some time to dig deeper given that we have a repro
at hand).
next prev parent reply other threads:[~2014-02-24 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 21:43 Jan Kratochvil
2014-02-24 21:55 ` Doug Evans
2014-02-24 22:04 ` Jan Kratochvil
2014-02-24 22:59 ` Doug Evans [this message]
2014-02-25 8:13 ` Jan Kratochvil
2014-02-25 21:37 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22SWQMhT0VQ=ryAQd_a4LNMTeGfke+qcgwewxaS3_qQKAg@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox