Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] gdb_assert -> complaint for weird DWARF
Date: Tue, 25 Feb 2014 08:13:00 -0000	[thread overview]
Message-ID: <20140225081348.GA11308@host2.jankratochvil.net> (raw)
In-Reply-To: <CADPb22SWQMhT0VQ=ryAQd_a4LNMTeGfke+qcgwewxaS3_qQKAg@mail.gmail.com>

On Mon, 24 Feb 2014 23:59:50 +0100, Doug Evans wrote:
> Can you send me the binaries for repro?

It was sent in the previous mail:
	http://people.redhat.com/jkratoch/gcc-debuginfo-4.8.2-7.fc20.x86_64-gnatbind.debug


> We could probably generate a good testcase for gdb from that.

I was thinking about it but:
 * There is not much to test gdb_assert vs. complaint.
 * Currently I believe the generated DWARF is incorrect.  Detecting that such
   incorrect DWARF is identified as an incorrect one has limited sense IMO.

So far I find it just a GCC bug.


> Another worry I have is that if my expectation that we shouldn't be
> recursively calling process_die (even for bad debug info) is wrong,
> then is there some obscure case where possible accidental re-reading
> of a DIE is actually needed by the current code to get the right
> answer (IOW is making this a complaint and returning also introducing
> a bug? Less of a bug than crashing or infinite recursion of course,
> but IWBN to invest some time to dig deeper given that we have a repro
> at hand).

As I said so far I do not find the DWARF (in the gnatbind case) to be
meaningful.


Jan


  reply	other threads:[~2014-02-25  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 21:43 Jan Kratochvil
2014-02-24 21:55 ` Doug Evans
2014-02-24 22:04   ` Jan Kratochvil
2014-02-24 22:59     ` Doug Evans
2014-02-25  8:13       ` Jan Kratochvil [this message]
2014-02-25 21:37       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140225081348.GA11308@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox