From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15120 invoked by alias); 24 Feb 2014 22:59:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15109 invoked by uid 89); 24 Feb 2014 22:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 24 Feb 2014 22:59:52 +0000 Received: by mail-vc0-f175.google.com with SMTP id ij19so6424990vcb.20 for ; Mon, 24 Feb 2014 14:59:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=A8B9Fst5al9JWshAw0Xv9xRUNHKc82LQ28LeNzzGHMo=; b=I33nbfCh4Twj6sv/4CVuurct6Hm7Xi5XCSuqZeGePSuiD4w8ko95I5cDdt2pchjNHS bIaa7hkCmbJbZCW6qQRCgDUrqFW86MSyMogLLvDAxKwyfe/I0CEvUsLd5H7wI2epWYOv cupk5c4ENUAktseQ+nTg+dh1v17P8SJS0CM3G6+HpdNXrqaDETIvpbDdjnigJsR0sBEq Ln48Yml4dnrKF69w4q583Pl8e3SGu7TG8AIqK2Stdf3liiO9TLFdHwJcdqkHiFla6teM u/TQDmS80/0acA3bOrfntYmwxXUHJI5zs2SBeHxi3Mp+upGVtnjDUBu0j3GUZTOf30me l09g== X-Gm-Message-State: ALoCoQl5j/fzwedTtsnLp2DiJbuYUN+M9xTAWaM8TDltR2ZX+0EASPZEPrWYHcBUIYBp9OWePCg/5KeGJqg2aRM77a4HxrL3wpVQ8Q5gmRdkB1U8NdXTwXo8EeFEXJG8LhBTLtVzmlx90illseACAFO2EjqKolFgWL/Mt6BoB0jiD8MKPwdiny4XwxLu9Y6F3Ki538VCremqyo70CcpzKuQo9zzxPEF+sQ== MIME-Version: 1.0 X-Received: by 10.221.66.73 with SMTP id xp9mr14442947vcb.27.1393282790411; Mon, 24 Feb 2014 14:59:50 -0800 (PST) Received: by 10.52.51.234 with HTTP; Mon, 24 Feb 2014 14:59:50 -0800 (PST) In-Reply-To: <20140224220439.GA7121@host2.jankratochvil.net> References: <20140224214314.GA5700@host2.jankratochvil.net> <20140224220439.GA7121@host2.jankratochvil.net> Date: Mon, 24 Feb 2014 22:59:00 -0000 Message-ID: Subject: Re: [patch] gdb_assert -> complaint for weird DWARF From: Doug Evans To: Jan Kratochvil Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00736.txt.bz2 On Mon, Feb 24, 2014 at 2:04 PM, Jan Kratochvil wrote: > Hi Doug, > > On Mon, 24 Feb 2014 22:55:49 +0100, Doug Evans wrote: >> Can you dig into the details of why the assert is tripping? >> I'm not comfortable with adding more complaints without at least >> including documentation of details. > > I have filed the Fedora GCC bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1069382 > > This is all I can do now. My build of FSF GCC does not upset GDB. > > I agree the current situation is not great, IMO there is a gnat DWARF > generator bug. Can you send me the binaries for repro? I see in the above bug report an abstract_origin which is what the patch has specific code for to avoid tripping the assert. We could probably generate a good testcase for gdb from that. Another worry I have is that if my expectation that we shouldn't be recursively calling process_die (even for bad debug info) is wrong, then is there some obscure case where possible accidental re-reading of a DIE is actually needed by the current code to get the right answer (IOW is making this a complaint and returning also introducing a bug? Less of a bug than crashing or infinite recursion of course, but IWBN to invest some time to dig deeper given that we have a repro at hand).