From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR python/13351
Date: Wed, 01 Feb 2012 19:21:00 -0000 [thread overview]
Message-ID: <CADPb22S6=D8W0ouJfUVC0pd17Bs_RXPuz=GOQUyvQ5uM7RKAwg@mail.gmail.com> (raw)
In-Reply-To: <m3y5smbl0c.fsf@fleche.redhat.com>
On Wed, Feb 1, 2012 at 8:01 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
> lookup_symbol already works without a frame, if you pass in a block.
>
> To me it seemed reasonable to extend this to search the global blocks.
> After all, even with a block argument it might return a symbol from a
> global block -- it is just that there is no way to request this from the
> start.
>
> That is, I didn't see a particular compelling reason for the current
> restriction. What is the point of this error?
>
> What seems not-clean to you?
I'm ok with it now.
> Actually I wonder whether this patch goes far enough. I think perhaps
> it should be possible to write lookup_symbol(block = None) to get the
> no-frame behavior; and also lookup_symbol(block = some_frame) to take
> the block from an explicit frame.
Ok.
[please document that no-frame includes the case where the thread is running]
next prev parent reply other threads:[~2012-02-01 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 22:02 Tom Tromey
2012-01-31 23:23 ` Doug Evans
2012-02-01 11:52 ` Phil Muldoon
2012-02-01 16:03 ` Tom Tromey
2012-02-01 16:02 ` Tom Tromey
2012-02-01 19:21 ` Doug Evans [this message]
2012-02-01 10:41 ` Pedro Alves
2012-02-01 16:05 ` Tom Tromey
2012-02-01 16:12 ` Pedro Alves
2012-02-01 16:17 ` Tom Tromey
2012-02-07 18:05 ` Tom Tromey
2012-02-07 18:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22S6=D8W0ouJfUVC0pd17Bs_RXPuz=GOQUyvQ5uM7RKAwg@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox