From: Phil Muldoon <pmuldoon@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFA: fix PR python/13351
Date: Wed, 01 Feb 2012 11:52:00 -0000 [thread overview]
Message-ID: <4F29275E.2070403@redhat.com> (raw)
In-Reply-To: <CADPb22T79CrHOqFG2RJMf6DBg93Jytd8hr8NJxdW=U71AH3cEA@mail.gmail.com>
On 01/31/2012 11:13 PM, Doug Evans wrote:
> On Tue, Jan 31, 2012 at 1:59 PM, Tom Tromey<tromey@redhat.com> wrote:
>> This fixes PR python/13351.
>>
>> The bug is that gdb.lookup_symbol required a current frame, but this
>> restriction doesn't really make sense. It is ok to look up global
>> symbols without a current frame.
>>
>> This patch just lifts the restriction.
>>
>> This requires a doc review.
>>
>> Built and regtested on x86-64 Fedora 15.
>>
>> Tom
>>
>> 2012-01-31 Tom Tromey<tromey@redhat.com>
>>
>> PR python/13351:
>> * python/py-symbol.c (gdbpy_lookup_symbol): Work even when there
>> is no frame.
> I think a bit of discussion is needed. [Sorry!]
>
> There is also lookup_global_symbol.
> Are we sure we want lookup_symbol to work when there is no frame?
> [it doesn't feel very clean to me, but maybe I just need to look at it
> differently]
I agree that two APIs for the same functionality are a pain. However we
have to keep them for backwards compatibility.
However, can we not deprecated and even gut lookup_global_symbol to call
lookup_symbol with a frame?
Cheers,
Phil
next prev parent reply other threads:[~2012-02-01 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 22:02 Tom Tromey
2012-01-31 23:23 ` Doug Evans
2012-02-01 11:52 ` Phil Muldoon [this message]
2012-02-01 16:03 ` Tom Tromey
2012-02-01 16:02 ` Tom Tromey
2012-02-01 19:21 ` Doug Evans
2012-02-01 10:41 ` Pedro Alves
2012-02-01 16:05 ` Tom Tromey
2012-02-01 16:12 ` Pedro Alves
2012-02-01 16:17 ` Tom Tromey
2012-02-07 18:05 ` Tom Tromey
2012-02-07 18:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29275E.2070403@redhat.com \
--to=pmuldoon@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox