From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11654 invoked by alias); 1 Feb 2012 19:21:10 -0000 Received: (qmail 11646 invoked by uid 22791); 1 Feb 2012 19:21:09 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Feb 2012 19:20:56 +0000 Received: by vbip1 with SMTP id p1so1473284vbi.0 for ; Wed, 01 Feb 2012 11:20:55 -0800 (PST) Received: by 10.52.155.196 with SMTP id vy4mr13389023vdb.12.1328124055370; Wed, 01 Feb 2012 11:20:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.155.196 with SMTP id vy4mr13389018vdb.12.1328124055286; Wed, 01 Feb 2012 11:20:55 -0800 (PST) Received: by 10.220.204.195 with HTTP; Wed, 1 Feb 2012 11:20:55 -0800 (PST) In-Reply-To: References: Date: Wed, 01 Feb 2012 19:21:00 -0000 Message-ID: Subject: Re: RFA: fix PR python/13351 From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00021.txt.bz2 On Wed, Feb 1, 2012 at 8:01 AM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > lookup_symbol already works without a frame, if you pass in a block. > > To me it seemed reasonable to extend this to search the global blocks. > After all, even with a block argument it might return a symbol from a > global block -- it is just that there is no way to request this from the > start. > > That is, I didn't see a particular compelling reason for the current > restriction. =A0What is the point of this error? > > What seems not-clean to you? I'm ok with it now. > Actually I wonder whether this patch goes far enough. =A0I think perhaps > it should be possible to write lookup_symbol(block =3D None) to get the > no-frame behavior; and also lookup_symbol(block =3D some_frame) to take > the block from an explicit frame. Ok. [please document that no-frame includes the case where the thread is runnin= g]