From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)
Date: Tue, 24 Apr 2012 18:11:00 -0000 [thread overview]
Message-ID: <CADPb22RVS07r0VO6Esm4k-sxX3o1ARiNGi5pEmE5VNtezBNs4Q@mail.gmail.com> (raw)
In-Reply-To: <87sjftdo1k.fsf@fleche.redhat.com>
On Tue, Apr 24, 2012 at 10:42 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> a) How's the ChangeLog for this patch supposed to be? Can I make a
> Sergio> "generic" ChangeLog, saying something like `Remove unused variables from
> Sergio> files'?
>
> I'm afraid I will leave that question for someone who cares a bit more.
> Sorry about that.
fwiw, I'm all for not having to follow the rules that would impose
excessive typing in such cases.
There is precedent for, at least in whitespace cases, just listing the files.
I'm happy with that. So while you would have to list the files
touched, at least you wouldn't have to document the functions!
[One doesn't always have to list the files that are touched. A common
case is when you change the signature of a function and then say "All
callers updated."
However, that feels different enough that I have a preference for
listing the files touched in global cleanup operations.]
E.g.
* foo.c: Mumble.
* bar.c: Likewise.
* baz.c: Likewise.
next prev parent reply other threads:[~2012-04-24 18:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 23:05 Sergio Durigan Junior
2012-04-24 3:33 ` Doug Evans
2012-04-24 18:02 ` Sergio Durigan Junior
2012-04-24 12:16 ` Pedro Alves
2012-04-24 17:38 ` Jan Kratochvil
2012-04-24 17:42 ` Tom Tromey
2012-04-24 17:51 ` Pedro Alves
2012-05-02 5:30 ` Sergio Durigan Junior
2012-05-02 6:17 ` Michael Eager
2012-05-02 10:55 ` Pedro Alves
2012-05-18 18:46 ` Sergio Durigan Junior
2012-05-18 19:13 ` Tom Tromey
2012-05-18 21:05 ` Sergio Durigan Junior
2012-04-24 17:53 ` Sergio Durigan Junior
2012-04-24 20:07 ` Tom Tromey
2012-04-24 18:10 ` Sergio Durigan Junior
2012-04-24 17:49 ` Tom Tromey
2012-04-24 18:11 ` Doug Evans [this message]
2012-04-24 20:30 ` Joel Brobecker
2012-04-24 17:58 ` [PATCH] Refactor observer.sh to cleanup unused vars (was: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)) Sergio Durigan Junior
2012-04-24 17:59 ` [PATCH] Refactor observer.sh to cleanup unused vars Tom Tromey
2012-04-24 18:11 ` Sergio Durigan Junior
2012-04-24 18:04 ` Pedro Alves
2012-05-14 11:37 ` [PATCH] Refactor observer.sh to cleanup unused vars (was: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)) Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22RVS07r0VO6Esm4k-sxX3o1ARiNGi5pEmE5VNtezBNs4Q@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox