From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11381 invoked by alias); 24 Apr 2012 18:10:04 -0000 Received: (qmail 11337 invoked by uid 22791); 24 Apr 2012 18:10:02 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 18:09:49 +0000 Received: by vcbfy7 with SMTP id fy7so913967vcb.0 for ; Tue, 24 Apr 2012 11:09:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=cBD6mLTRq5NxET6+s+9KNt+MutQNl7frNW+Tp0UOT7g=; b=kwZSAhUMxldTTqLvQ1KYM9eqN+NZ9M1b/DMYBjls71x9FHGbsi3vft/mOhDys1bOH+ srvB587ts86+9+QFlxGTNEkZ/Z6djyQgll453BcahnAwk8xKdF8IxZ8JpZi0vutq8/3w S66JXJxm+1cSdmZgtBRnSC4rMbsx9LSLl3MFbd95J1S38oT35KEKQ9QgX/sgKTGAcpSK RTFBmJwnK/TIB6RIfe7uAkHYgTnR5tz5EzpXA8QYuSwDx3X2o3yPnxqIK3LhyE/deSkw DsM/iOkFJctV1HD0BH3yGIPFQ1ubN6Yreig+EOoDYiYOhm5Ktq+RorqHdrXU3PQ4waHA hDnw== Received: by 10.52.74.69 with SMTP id r5mr1757160vdv.110.1335290989069; Tue, 24 Apr 2012 11:09:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.74.69 with SMTP id r5mr1757148vdv.110.1335290988972; Tue, 24 Apr 2012 11:09:48 -0700 (PDT) Received: by 10.52.165.2 with HTTP; Tue, 24 Apr 2012 11:09:48 -0700 (PDT) In-Reply-To: <87sjftdo1k.fsf@fleche.redhat.com> References: <87sjftdo1k.fsf@fleche.redhat.com> Date: Tue, 24 Apr 2012 18:11:00 -0000 Message-ID: Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag) From: Doug Evans To: Tom Tromey Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQnBsejOvxM/3ZECxuv/gHEcyrOtKsOZ26njFcWKUG0h0jlJUw9YeW/TP+f3kxFk8XLz7LtUJh496XgsYn5lD9QCRjHDAnDceEGK2XJjv+QqzYj01Ysjm/xN9uwALiDXJo4KKbyrhNiZ8ud1iFjGUg4oUzZNLg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00819.txt.bz2 On Tue, Apr 24, 2012 at 10:42 AM, Tom Tromey wrote: >>>>>> "Sergio" =3D=3D Sergio Durigan Junior writes: > > Sergio> a) How's the ChangeLog for this patch supposed to be? =A0Can I ma= ke a > Sergio> "generic" ChangeLog, saying something like `Remove unused variabl= es from > Sergio> files'? > > I'm afraid I will leave that question for someone who cares a bit more. > Sorry about that. fwiw, I'm all for not having to follow the rules that would impose excessive typing in such cases. There is precedent for, at least in whitespace cases, just listing the file= s. I'm happy with that. So while you would have to list the files touched, at least you wouldn't have to document the functions! [One doesn't always have to list the files that are touched. A common case is when you change the signature of a function and then say "All callers updated." However, that feels different enough that I have a preference for listing the files touched in global cleanup operations.] E.g. * foo.c: Mumble. * bar.c: Likewise. * baz.c: Likewise.