Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)

[Michael Eager <eager@eagerm.com>]

On 05/01/2012 10:30 PM, Sergio Durigan Junior wrote:
> On Tuesday, April 24 2012, Pedro Alves wrote:
>
>> On 04/24/2012 06:39 PM, Tom Tromey wrote:
>>
>>>>>>>> "Pedro" == Pedro Alves<palves@redhat.com>  writes:
>>>
>>> Pedro>  There's no need to commit all this in one go.  Once you split,
>>> Pedro>  some of the resulting patches will be dead obvious, and will end up
>>> Pedro>  reviewed (if even necessary) and checked in quickly, and thus you end up
>>> Pedro>  making progress faster that way.
>>>
>>> It seems to me that a variable that is declared but not initialized and
>>> not used is always going to be obviously dead.  I'd be comfortable with
>>> pre-approving all such removals; leaving review for the patches to the
>>> generators and initialized variables.
>>
>>
>> Yes, that seems like a good cut.
>
> Ok, sorry for taking so long to respond, this patch is huge and I was
> doing something else...
>
> Well, here's the "obvious" patch that I came up with.  It contains only
> declarations of variables, not assignments to them.
>
> I know it's "obvious", but I prefer to ask than to apologize, so: is it
> OK to apply?
>
> Of course, if you really want some rationale to the changes below, I
> will need to dive into the code and see why those variables are not
> used.
>
> OK to apply?

OK (obvious) for Microblaze.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077