Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: aarch64-tdep.c:aarch64_skip_prologue oddity, what's going on???
Date: Wed, 27 Aug 2014 01:08:00 -0000	[thread overview]
Message-ID: <CADPb22R2onkjBq7JdkW50gjLa6tP=QQCd1CttWCMCm7_xWY13g@mail.gmail.com> (raw)
In-Reply-To: <yjt2bnr6rbng.fsf@ruffy.mtv.corp.google.com>

On Tue, Aug 26, 2014 at 5:58 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> I'm trying to fix a few clang-related testsuite failures.
> amd64,i386,arm have checks for symtab->producer == clang,
> and the problem is this code doesn't check whether
> symtab->language == language_asm.
> I could fix the bug in all three places, but I think some consolidation
> is in order here (I'd rather fix it in one place instead of three).

OTOH, I can see an argument for skip_prologue_using_sal to early exit
for assembler.
I still think some consolidation is in order though.
And my questions regarding gdbarch_skip_prologue oddities are still open.


  reply	other threads:[~2014-08-27  1:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  0:58 Doug Evans
2014-08-27  1:08 ` Doug Evans [this message]
2014-08-28  2:25 ` Yao Qi
2014-09-02 23:47   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22R2onkjBq7JdkW50gjLa6tP=QQCd1CttWCMCm7_xWY13g@mail.gmail.com' \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox