From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115275-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16909 invoked by alias); 27 Aug 2014 01:08:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16896 invoked by uid 89); 27 Aug 2014 01:08:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yh0-f46.google.com
Received: from mail-yh0-f46.google.com (HELO mail-yh0-f46.google.com) (209.85.213.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 01:08:03 +0000
Received: by mail-yh0-f46.google.com with SMTP id a41so12658594yho.5        for <gdb-patches@sourceware.org>; Tue, 26 Aug 2014 18:08:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:content-type;        bh=lE/M6rxWD48Cjf1owkO1S6+MWXhb0vLaxXfD8/ptkXs=;        b=aSS6ophlKzXqYuqYhECtvp/5qme6HQRCz7TelGhV8mOdEzgBuQNFtZkQuhO5Htl/Pe         XOIxuhFSwF8a/4i5c6FGAR5D2bw98lmE8Kc2rIj4J2GJ++LnRU0e09R3RQIrbKyUO+Po         XFHVlArxg9UpfVlwGPXVEvl1oPyC7kkm56bYN6jMwRmKPf+q9T4bQA8x3FRirIMhlJRy         60EoRfRBb/ZeIhxaSkayuQEUGndAMBBVqDqAWG3hY6W3bRzkMqD2qj9aLvSH8p1Lk8Mq         MzwvrG+XpDmsYKtCVFMvppuCRbqbfv6xitqm9gKazfRFzzJziu6Aa7QhQtCtMXC170DL         T9gA==
X-Gm-Message-State: ALoCoQkWhXFQ9mCL083iHpzXukmtgzKTGWL/YlgrDYzhmAqSEG2T+22B6rVBDREBLOiQDSpxpHGO
MIME-Version: 1.0
X-Received: by 10.52.164.80 with SMTP id yo16mr11966944vdb.44.1409101681240; Tue, 26 Aug 2014 18:08:01 -0700 (PDT)
Received: by 10.52.136.203 with HTTP; Tue, 26 Aug 2014 18:08:01 -0700 (PDT)
In-Reply-To: <yjt2bnr6rbng.fsf@ruffy.mtv.corp.google.com>
References: <yjt2bnr6rbng.fsf@ruffy.mtv.corp.google.com>
Date: Wed, 27 Aug 2014 01:08:00 -0000
Message-ID: <CADPb22R2onkjBq7JdkW50gjLa6tP=QQCd1CttWCMCm7_xWY13g@mail.gmail.com>
Subject: Re: aarch64-tdep.c:aarch64_skip_prologue oddity, what's going on???
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-08/txt/msg00540.txt.bz2

On Tue, Aug 26, 2014 at 5:58 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> I'm trying to fix a few clang-related testsuite failures.
> amd64,i386,arm have checks for symtab->producer == clang,
> and the problem is this code doesn't check whether
> symtab->language == language_asm.
> I could fix the bug in all three places, but I think some consolidation
> is in order here (I'd rather fix it in one place instead of three).

OTOH, I can see an argument for skip_prologue_using_sal to early exit
for assembler.
I still think some consolidation is in order though.
And my questions regarding gdbarch_skip_prologue oddities are still open.