Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: aarch64-tdep.c:aarch64_skip_prologue oddity, what's going on???
Date: Tue, 02 Sep 2014 23:47:00 -0000	[thread overview]
Message-ID: <21510.22311.680165.882445@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <878um9gxrt.fsf@codesourcery.com>

Yao Qi writes:
 > Doug Evans <dje@google.com> writes:
 > 
 > > So, second question: Can we remove both the above call to
 > > find_pc_partial_function, and the second call to skip_prologue_using_sal?
 > > Or, under what circumstances will the second call to
 > > skip_prologue_using_sal return a non-zero value?
 > 
 > Is it https://www.sourceware.org/ml/gdb/2008-09/msg00111.html the case?
 > The fix is about ARM, but looks the problem is arch independent.

Thanks!

I looked at this and I'm still confused why the code is the way it is,
it seems unnecessarily complex (not massively so of course, just that
some useful simplification is possible (I think!).

I've got a patch to post.
Hopefully it will help someone clear things up.


      reply	other threads:[~2014-09-02 23:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  0:58 Doug Evans
2014-08-27  1:08 ` Doug Evans
2014-08-28  2:25 ` Yao Qi
2014-09-02 23:47   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21510.22311.680165.882445@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox