From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 560 invoked by alias); 2 Sep 2014 23:47:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 549 invoked by uid 89); 2 Sep 2014 23:47:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f202.google.com Received: from mail-qc0-f202.google.com (HELO mail-qc0-f202.google.com) (209.85.216.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 02 Sep 2014 23:47:55 +0000 Received: by mail-qc0-f202.google.com with SMTP id r5so874985qcx.1 for ; Tue, 02 Sep 2014 16:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=i/3fyTJfE3u/wo7iDcSRWM4h503uN27f5ITsZ7H1EB0=; b=jwBQdCZ4dzr6ndYR+WeC5iOgwEsQ3k8LM0AiGNt+yNWPxnIcdnMzDs2DrXnh8Ddz6L ZKIQxYi5ASNtinl2bSslaBAPytnzAPFZvmB212JmIp+SUn2H7voR9nog/hxgzSP+G0CK SrUwK5IVLpWY2c8nGVTbwVTlRCWwzJ+Uhn+IP6xmvfFBu2aElxKDtXyfBJ0P5FR1UXsL bcLmgH381GbVSey1KPX5iLIfOa8fP/b6X2fvafPnwHCYcNnS6gmnN/gShI5b+46Uevv4 uMmqQ0AmfkvB7giVuUolCPzzh4vOXijZz8ymm1dKGghj1LNm/WdDOvPS3rKI+CJb5OPz JlxQ== X-Gm-Message-State: ALoCoQmNEOH/yNHZv/l5x+5n+Y4DHDQsRpR106kl66Uziexvc7vSZSy/S5Ywht7kMpzUv5CmupfC X-Received: by 10.52.174.178 with SMTP id bt18mr21118092vdc.1.1409701672775; Tue, 02 Sep 2014 16:47:52 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id d7si737623yho.2.2014.09.02.16.47.52 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Sep 2014 16:47:52 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 3881D5A4355; Tue, 2 Sep 2014 16:47:52 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21510.22311.680165.882445@ruffy2.mtv.corp.google.com> Date: Tue, 02 Sep 2014 23:47:00 -0000 To: Yao Qi Cc: Subject: Re: aarch64-tdep.c:aarch64_skip_prologue oddity, what's going on??? In-Reply-To: <878um9gxrt.fsf@codesourcery.com> References: <878um9gxrt.fsf@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00078.txt.bz2 Yao Qi writes: > Doug Evans writes: > > > So, second question: Can we remove both the above call to > > find_pc_partial_function, and the second call to skip_prologue_using_sal? > > Or, under what circumstances will the second call to > > skip_prologue_using_sal return a non-zero value? > > Is it https://www.sourceware.org/ml/gdb/2008-09/msg00111.html the case? > The fix is about ARM, but looks the problem is arch independent. Thanks! I looked at this and I'm still confused why the code is the way it is, it seems unnecessarily complex (not massively so of course, just that some useful simplification is possible (I think!). I've got a patch to post. Hopefully it will help someone clear things up.