From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix c++/16253 (tag/variable name collision)
Date: Wed, 28 May 2014 17:55:00 -0000 [thread overview]
Message-ID: <CADPb22QqkWhjP6rzRxZGgjRb8y80n5HFvOVbnC2YKVB2pLxNzw@mail.gmail.com> (raw)
In-Reply-To: <87lhvdnd1p.fsf@fleche.redhat.com>
On Thu, Apr 10, 2014 at 1:29 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> I am reposting the entire patch for review. The only difference
> Keith> between this and the original version is the exclusion of the patch
> Keith> mentioned above.
>
> Thanks Keith.
>
> I like this patch quite a lot.
> It gets rid of symbol_matches_domain -- that's fantastic.
Awesome indeed.
Alas it trips over gdb's sucky symbol lookup and introduces a perf regression.
info fun ^foo::(anonymous namespace)
goes from about a minute to a very long time (longer than I wanted to wait :-)).
["foo" is renamed to protect the innocent. 1/2 :-)]
I've reopened 16253 and filed 16994.
One possibility is to revert the patch for 7.8.
I've confirmed doing that removes the perf regression.
I'd like to see if we can take a small step to fixing gdb's symbol
lookup that will fix the perf regression.
next prev parent reply other threads:[~2014-05-28 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 18:12 Keith Seitz
2014-03-24 14:15 ` Joel Brobecker
2014-03-25 18:11 ` Keith Seitz
2014-03-26 13:32 ` Joel Brobecker
2014-03-26 13:40 ` Joel Brobecker
2014-03-26 15:34 ` Keith Seitz
2014-04-10 18:54 ` Keith Seitz
2014-04-10 20:29 ` Tom Tromey
2014-05-28 17:55 ` Doug Evans [this message]
2014-04-17 19:03 ` Regression for gdb.cp/koenig.exp: p entry (c) [Re: [RFA] Fix c++/16253 (tag/variable name collision)] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22QqkWhjP6rzRxZGgjRb8y80n5HFvOVbnC2YKVB2pLxNzw@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox