From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22414 invoked by alias); 28 May 2014 17:55:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22403 invoked by uid 89); 28 May 2014 17:55:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f172.google.com Received: from mail-vc0-f172.google.com (HELO mail-vc0-f172.google.com) (209.85.220.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 May 2014 17:55:41 +0000 Received: by mail-vc0-f172.google.com with SMTP id ik5so9446406vcb.17 for ; Wed, 28 May 2014 10:55:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=V5UpGPEG1j5QTzOWyvHMBGi22b805VVazgKg01DEDiQ=; b=ZjgJT5APlnID87VukN0MP5Py0bSmP2NL880pE7+cvh9VAcXf6+XvcylIpF8AxlX8Ka L2GqSQKYzLa6ar0xgNRxqmc5G+eua16j6vVwDhOUC8JgIJA4XCg2IOJxwzZqoxZ6yzeO zabFwu6YU0HRm3OlUQgIgnApEEywCQlxOTpItsJF3mHyGw6y14t5VFXPTwNQhLuKpmJW 5Inbko8w7+h5D6J2Zo/aSeRp6CdDgX/1eu3EpOXQevG+fD/rZ1vCUsKtLtX8g5E0rkUi hTKgUXpBJgeiMT7sfcKFCt8LVOmZZYZUGG8VPoeVhaQbImk9NwuF/NY5tNo/Cg6iORY2 1Mtw== X-Gm-Message-State: ALoCoQmuvXDEiF2FsyDKdjuZfq0J8HSEoy8LGpWpUpEyQBtynjwnxoVC+UYwKhJ8GZhHhdQZH0fQ MIME-Version: 1.0 X-Received: by 10.220.249.198 with SMTP id ml6mr1630768vcb.36.1401299738807; Wed, 28 May 2014 10:55:38 -0700 (PDT) Received: by 10.52.28.230 with HTTP; Wed, 28 May 2014 10:55:38 -0700 (PDT) In-Reply-To: <87lhvdnd1p.fsf@fleche.redhat.com> References: <532C810F.7010809@redhat.com> <20140326134048.GA24501@adacore.com> <5346E8EA.1070705@redhat.com> <87lhvdnd1p.fsf@fleche.redhat.com> Date: Wed, 28 May 2014 17:55:00 -0000 Message-ID: Subject: Re: [RFA] Fix c++/16253 (tag/variable name collision) From: Doug Evans To: Tom Tromey Cc: Keith Seitz , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00695.txt.bz2 On Thu, Apr 10, 2014 at 1:29 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> I am reposting the entire patch for review. The only difference > Keith> between this and the original version is the exclusion of the patch > Keith> mentioned above. > > Thanks Keith. > > I like this patch quite a lot. > It gets rid of symbol_matches_domain -- that's fantastic. Awesome indeed. Alas it trips over gdb's sucky symbol lookup and introduces a perf regression. info fun ^foo::(anonymous namespace) goes from about a minute to a very long time (longer than I wanted to wait :-)). ["foo" is renamed to protect the innocent. 1/2 :-)] I've reopened 16253 and filed 16994. One possibility is to revert the patch for 7.8. I've confirmed doing that removes the perf regression. I'd like to see if we can take a small step to fixing gdb's symbol lookup that will fix the perf regression.