Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] buildsym.c cleanup
Date: Tue, 20 Aug 2013 19:00:00 -0000	[thread overview]
Message-ID: <CADPb22QX-_vn92m7qwDw6101roLZgcMF64VuSZ++ZSXY11ZncQ@mail.gmail.com> (raw)
In-Reply-To: <87txjm7fid.fsf@fleche.redhat.com>

On Mon, Jul 22, 2013 at 8:58 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> On Mon, May 20, 2013 at 2:03 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>>>> I have no idea about the COFF change.  It isn't clear to me whether
>>>> coffread and stabsread expect to share the same globals or not.
>>>
>>> I do not have a real idea either, but looking at the code, I do not
>>> think so. The indices used to index the types seem completely
>>> unrelated...
>
> Doug> Hi.  So what's the verdict here?
> Doug> Should we wait until we can find someone to test this on coff, or
> Doug> check the patch in now.
>
> Joel said he thinks the globals aren't shared.
> If you agree then I think it is fine to go ahead and put it in.

Committed.

For reference sake, I did an m32r-coff port of binutils,gcc,newlib,gdb
to do some additional testing.
[found some m32r issues, which is good, and I now have a simple port
from which to do further coff testing should it be necessary - though
I'm happy to see coff go anytime. :-)]


      reply	other threads:[~2013-08-20 19:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 16:03 Doug Evans
2013-05-14 18:01 ` Tom Tromey
2013-05-20  9:03   ` Joel Brobecker
2013-07-19 23:18     ` Doug Evans
2013-07-22 15:59       ` Tom Tromey
2013-08-20 19:00         ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22QX-_vn92m7qwDw6101roLZgcMF64VuSZ++ZSXY11ZncQ@mail.gmail.com \
    --to=dje@google.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox