From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6441 invoked by alias); 20 Aug 2013 19:00:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6431 invoked by uid 89); 20 Aug 2013 19:00:58 -0000 X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 Received: from mail-qe0-f51.google.com (HELO mail-qe0-f51.google.com) (209.85.128.51) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 20 Aug 2013 19:00:57 +0000 Received: by mail-qe0-f51.google.com with SMTP id cy11so464429qeb.24 for ; Tue, 20 Aug 2013 12:00:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dk5w8Alc1F9KMNHCvvBubtzjzkbN7PiXSfCsM9BKU4M=; b=JeHAtwHB8NuYUauy30sfUUSO8AahYggGKLIscRWSx5yfCtqWfz2Kpz1FX2iwZo0F+6 TOthvOuH5wn+BCrbVyUpSCI7U765530vtvwRSP6/n3qvnv4WPjviAiOB87hKZFZvlsny StxHN4Vn3E1OHdGx87Q8kMhXdT/E3kAPnAMh3OWqYDC7UOhPA6TDX8ydBz2H4R2XuXN2 Ppz+NMOxE4F/JzxJRyLh/SbjWMigstnfltNBExjT/dTmqEYKXDZKFXEpDkduPwz083g7 rzDdYf/7XzRP14ck0rNzs6N6pRLmXEIZeqWTFrR8YTexlMnaKFbIbDncR9o9XRigXk0j 9xRw== X-Gm-Message-State: ALoCoQmFek7RK6h/NaU6vRj5hrzTpof7kSJrn9CxtMdHTm9M2W+ltgZIDyoDmUtezJJ+8i8A/2K+0Sf/eJYhxsSrC4LE2+bqB50pnJWDG9qCQIIoPZ/Bk34BfUl6g4ypbqH2hmoV3ndTahDaOXqfxP1qhhC/7Xt+s4Txf6qFwkLio5qBzYAe5jrwV4/w9UOSJ1iwLiCzIQvVHhECixsdIo0Kn3q8r7aCIw== MIME-Version: 1.0 X-Received: by 10.49.71.147 with SMTP id v19mr3979774qeu.54.1377025256115; Tue, 20 Aug 2013 12:00:56 -0700 (PDT) Received: by 10.229.145.20 with HTTP; Tue, 20 Aug 2013 12:00:55 -0700 (PDT) In-Reply-To: <87txjm7fid.fsf@fleche.redhat.com> References: <87ehd95tl6.fsf@fleche.redhat.com> <20130520090312.GM4017@adacore.com> <87txjm7fid.fsf@fleche.redhat.com> Date: Tue, 20 Aug 2013 19:00:00 -0000 Message-ID: Subject: Re: [RFA] buildsym.c cleanup From: Doug Evans To: Tom Tromey Cc: Joel Brobecker , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-08/txt/msg00556.txt.bz2 On Mon, Jul 22, 2013 at 8:58 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> On Mon, May 20, 2013 at 2:03 AM, Joel Brobecker wrote: >>>> I have no idea about the COFF change. It isn't clear to me whether >>>> coffread and stabsread expect to share the same globals or not. >>> >>> I do not have a real idea either, but looking at the code, I do not >>> think so. The indices used to index the types seem completely >>> unrelated... > > Doug> Hi. So what's the verdict here? > Doug> Should we wait until we can find someone to test this on coff, or > Doug> check the patch in now. > > Joel said he thinks the globals aren't shared. > If you agree then I think it is fine to go ahead and put it in. Committed. For reference sake, I did an m32r-coff port of binutils,gcc,newlib,gdb to do some additional testing. [found some m32r issues, which is good, and I now have a simple port from which to do further coff testing should it be necessary - though I'm happy to see coff go anytime. :-)]