From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] buildsym.c cleanup
Date: Tue, 14 May 2013 18:01:00 -0000 [thread overview]
Message-ID: <87ehd95tl6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <yjt2fvxpwnu0.fsf@ruffy.mtv.corp.google.com> (Doug Evans's message of "Tue, 14 May 2013 09:03:35 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> Regression tested on amd64-linux, and a second time with -gstabs.
Doug> I didn't check coff though, however the change is mechanical.
Doug> Can someone test this on coff, or is this ok to check in now?
I think the subfile_stack and macro-related bits are ok.
I have no idea about the COFF change. It isn't clear to me whether
coffread and stabsread expect to share the same globals or not.
Doug> [I think there's more that can be done here,
Doug> but I think this can go in now.]
Yeah, there is really no good reason for this module to have any globals
at all. Unfortunately, untangling it all always seemed to be a pain.
Tom
next prev parent reply other threads:[~2013-05-14 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:03 Doug Evans
2013-05-14 18:01 ` Tom Tromey [this message]
2013-05-20 9:03 ` Joel Brobecker
2013-07-19 23:18 ` Doug Evans
2013-07-22 15:59 ` Tom Tromey
2013-08-20 19:00 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehd95tl6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox