From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification
Date: Wed, 18 Sep 2013 17:10:00 -0000 [thread overview]
Message-ID: <CADPb22Q-SEEpDjK6i4KMZ1JTp2+A5bS+e1YZJ1QFNo1Unp8gkA@mail.gmail.com> (raw)
In-Reply-To: <20130918140806.GA9628@host2.jankratochvil.net>
On Wed, Sep 18, 2013 at 7:08 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> gdb/
> 2013-09-18 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Constification.
> * main.c (captured_main): Wrap symbol_file_add_main calls with
> TRY_CATCH. Twice.
> * symfile.c (symbol_file_add_main_1): Make args parameter const.
> (symbol_file_add): Make name parameter const.
> (symbol_file_add_main, symbol_file_add_main_1): Make args parameter const.
> (symfile_bfd_open): Make name parameter const, rename it to cname. Add
> variable name. Change their usage accordingly.
> * symfile.h (symbol_file_add, symfile_bfd_open): Make first parameter
> const.
> (symbol_file_add_main): Make args parameter const.
LGTM (modulo updating ChangeLog entry for captured_main).
thanks
next prev parent reply other threads:[~2013-09-18 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 19:37 Jan Kratochvil
2013-09-16 22:22 ` Doug Evans
2013-09-17 6:48 ` Jan Kratochvil
2013-09-17 18:39 ` Tom Tromey
2013-09-17 19:24 ` Doug Evans
2013-09-17 19:32 ` Tom Tromey
2013-09-17 19:37 ` Jan Kratochvil
2013-09-17 19:50 ` Doug Evans
2013-09-18 13:45 ` Joel Brobecker
2013-09-18 14:08 ` Jan Kratochvil
2013-09-18 17:10 ` Doug Evans [this message]
2013-09-19 12:45 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Q-SEEpDjK6i4KMZ1JTp2+A5bS+e1YZJ1QFNo1Unp8gkA@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox