From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification
Date: Tue, 17 Sep 2013 06:48:00 -0000 [thread overview]
Message-ID: <20130917064841.GA18677@host2.jankratochvil.net> (raw)
In-Reply-To: <21047.33940.998451.19883@ruffy.mtv.corp.google.com>
On Tue, 17 Sep 2013 00:22:12 +0200, Doug Evans wrote:
> Jan Kratochvil writes:
> > - catch_command_errors (symbol_file_add_main, symarg,
> > - !batch_flag, RETURN_MASK_ALL);
> > + {
> > + volatile struct gdb_exception e;
> > +
> > + TRY_CATCH (e, RETURN_MASK_ALL)
> > + {
> > + symbol_file_add_main (symarg, !batch_flag);
> > + }
> > + exception_print (gdb_stderr, e);
> > + }
> > }
> >
> > if (corearg && pidarg)
>
> There is catch_command_errors_const.
> Would that work here?
It would work here. But I thought catch_command_errors* is deprecated in
favor of TRY_CATCH. Maybe I could split this patch in two, but the end would
be the same.
Jan
next prev parent reply other threads:[~2013-09-17 6:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 19:37 Jan Kratochvil
2013-09-16 22:22 ` Doug Evans
2013-09-17 6:48 ` Jan Kratochvil [this message]
2013-09-17 18:39 ` Tom Tromey
2013-09-17 19:24 ` Doug Evans
2013-09-17 19:32 ` Tom Tromey
2013-09-17 19:37 ` Jan Kratochvil
2013-09-17 19:50 ` Doug Evans
2013-09-18 13:45 ` Joel Brobecker
2013-09-18 14:08 ` Jan Kratochvil
2013-09-18 17:10 ` Doug Evans
2013-09-19 12:45 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917064841.GA18677@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox