From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8614 invoked by alias); 17 Sep 2013 06:48:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8541 invoked by uid 89); 17 Sep 2013 06:48:47 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2013 06:48:47 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8H6miGf023331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Sep 2013 02:48:45 -0400 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8H6mfhd000797 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 17 Sep 2013 02:48:44 -0400 Date: Tue, 17 Sep 2013 06:48:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification Message-ID: <20130917064841.GA18677@host2.jankratochvil.net> References: <20130915193742.GA20411@host2.jankratochvil.net> <21047.33940.998451.19883@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21047.33940.998451.19883@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00486.txt.bz2 On Tue, 17 Sep 2013 00:22:12 +0200, Doug Evans wrote: > Jan Kratochvil writes: > > - catch_command_errors (symbol_file_add_main, symarg, > > - !batch_flag, RETURN_MASK_ALL); > > + { > > + volatile struct gdb_exception e; > > + > > + TRY_CATCH (e, RETURN_MASK_ALL) > > + { > > + symbol_file_add_main (symarg, !batch_flag); > > + } > > + exception_print (gdb_stderr, e); > > + } > > } > > > > if (corearg && pidarg) > > There is catch_command_errors_const. > Would that work here? It would work here. But I thought catch_command_errors* is deprecated in favor of TRY_CATCH. Maybe I could split this patch in two, but the end would be the same. Jan