From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30854 invoked by alias); 18 Sep 2013 17:10:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30841 invoked by uid 89); 18 Sep 2013 17:10:36 -0000 Received: from mail-ie0-f170.google.com (HELO mail-ie0-f170.google.com) (209.85.223.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Sep 2013 17:10:36 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f170.google.com Received: by mail-ie0-f170.google.com with SMTP id x13so13737338ief.29 for ; Wed, 18 Sep 2013 10:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=hF4RznKDrIC3MfVQDfRVMLKZ/DAaDVEW5V73DrgN2j8=; b=RRpg6ND5mdISPoWdwgAXdphKN5g77+lmj6D+fLwdvOgxVMC/YbSaNeEojPs47u27eh iF5CkvzWyCj55hc6ecW/NPQlSh42GgjYRXU9dwKKuUr/HzsWrDsrjoMVWp640u+BAIUd zKwQmvUOeI6LGmvKOwx3a/5UWWkOcVS3UxbmREERaol9yymbghluXChnrYGrDtK1q97F bZpZkLMfJ/oFWYZe5tDsUXeAh/GKumQXz1efkrEPfcBy/XZc2ffaHYi/L6R5nyM4PGnp mTO7X9RRmkRqCpCyyXBu1gjqq3nHH52Pp7oyDlV/1AGZ/PWDY5X5Ta3iHD095lY/wtWw Ez3A== X-Gm-Message-State: ALoCoQkTI714r+YP4WHOBPb9dkD4fRuDGoqOQyqEmjrDLUf7ae5i2Drg07ojxcAH3ofWA5Z4kg6PqugFjFDT4k//q4LOU3yW0qNQeEYHmNYN2A0XnkQ3HryU5FDcE73ckOUkeXfEwVsLoKGalwUHM5d76gg15PtuYW5NtAynWjfzkWWKwzUysocmV4h/LG/VWXmBEnAjOx83khDYHhDkaorCroxaEHWJeg== MIME-Version: 1.0 X-Received: by 10.50.55.65 with SMTP id q1mr3565441igp.4.1379524234148; Wed, 18 Sep 2013 10:10:34 -0700 (PDT) Received: by 10.64.31.100 with HTTP; Wed, 18 Sep 2013 10:10:34 -0700 (PDT) In-Reply-To: <20130918140806.GA9628@host2.jankratochvil.net> References: <20130915193742.GA20411@host2.jankratochvil.net> <21047.33940.998451.19883@ruffy.mtv.corp.google.com> <20130918140806.GA9628@host2.jankratochvil.net> Date: Wed, 18 Sep 2013 17:10:00 -0000 Message-ID: Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification From: Doug Evans To: Jan Kratochvil Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00611.txt.bz2 On Wed, Sep 18, 2013 at 7:08 AM, Jan Kratochvil wrote: > gdb/ > 2013-09-18 Jan Kratochvil > > Constification. > * main.c (captured_main): Wrap symbol_file_add_main calls with > TRY_CATCH. Twice. > * symfile.c (symbol_file_add_main_1): Make args parameter const. > (symbol_file_add): Make name parameter const. > (symbol_file_add_main, symbol_file_add_main_1): Make args parameter const. > (symfile_bfd_open): Make name parameter const, rename it to cname. Add > variable name. Change their usage accordingly. > * symfile.h (symbol_file_add, symfile_bfd_open): Make first parameter > const. > (symbol_file_add_main): Make args parameter const. LGTM (modulo updating ChangeLog entry for captured_main). thanks